Remove SAS Generation Methods from Clients #5617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanGiles
approved these changes
Oct 1, 2019
alzimmermsft
requested review from
gapra-msft,
jaschrep-msft,
rickle-msft and
sima-zhu
as code owners
JonathanGiles
requested changes
Oct 2, 2019
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobSasConstructor.java
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobSasConstructor.java
Outdated
Show resolved
Hide resolved
joshfree
approved these changes
Oct 3, 2019
sima-zhu
approved these changes
Oct 3, 2019
chrischild
pushed a commit
to chrischild/azure-sdk-for-java
that referenced
this pull request
Oct 5, 2019
* Remove SAS generation methods from Azure Blob clients * Add some resource type logic to BlobServiceSASSignatureValues * Fix failing test * Removed SAS token methods in Queue clients * Fixing some more tests * Fix Javadoc links * Fixing linting issues, prototyping BlobSasConstructor * Minor refactoring in new class * Re-record failing tests * Fix checkstyle issues * Fix accidentally method name change * Fix javadoc issue * Cleanup checkstyle issues * Make SAS generation classes public API * Fixing checkstyle issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5541