Readme update for sasToken API in builder #5697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sima-zhu
requested review from
alzimmermsft,
gapra-msft,
jaschrep-msft and
rickle-msft
as code owners
alzimmermsft
reviewed
Oct 4, 2019
| - Renamed `setTier` to `setAccessTier` from `BlobAsyncClientBase` and `BlobClientBase` classes. | ||
| - Added `ParallelTransferOptions` to buffered upload, upload from file and download to file methods. | ||
| - Removed `Metadata` class and uses Map<String, String> for `matadata` field of `BlobProperties` and `ContainerProperties`. | ||
| - Removed generate SAS token APIs. |
Member
There was a problem hiding this comment.
Suggested change
| - Removed generate SAS token APIs. | |
| - Removed SAS token generation methods for client APIs, use {insert SAS token generation classes here} to create SAS tokens. |
alzimmermsft
reviewed
Oct 4, 2019
| - Added `ParallelTransferOptions` to buffered upload, upload from file and download to file methods. | ||
| - Removed `Metadata` class and uses Map<String, String> for `matadata` field of `BlobProperties` and `ContainerProperties`. | ||
| - Removed generate SAS token APIs. | ||
| - Added `sasToken(String)` in client builder. |
Member
There was a problem hiding this comment.
Suggested change
| - Added `sasToken(String)` in client builder. | |
| - Replaced `credential(SASTokenCredential)` with `sasToken(String)` in client builder. |
alzimmermsft
reviewed
Oct 4, 2019
| - Added `ParallelTransferOptions` to buffered upload, upload from file and download to file methods. | ||
| - Removed `Metadata` class and uses Map<String, String> for `matadata` field of `BlobProperties` and `ContainerProperties`. | ||
| - Removed generate SAS token APIs. | ||
| - Added `sasToken(String)` in client builder. |
Member
There was a problem hiding this comment.
Add a comment about removing SASTokenCredential and SASTokenCredentialPolicy
alzimmermsft
approved these changes
Oct 4, 2019
Contributor
Author
|
Comments addressed |
chrischild
pushed a commit
to chrischild/azure-sdk-for-java
that referenced
this pull request
Oct 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.