Skip to content

Remove some usages of internal APIs in samples #5186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antkmsft merged 5 commits into from
Nov 28, 2023
Merged

Remove some usages of internal APIs in samples #5186

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3d4d446
Remove some usages of internal APIs in samples
antkmsft Nov 24, 2023
6f53aad
Merge branch 'main' into samples-internal
antkmsft Nov 27, 2023
00e506f
Merge branch 'main' into samples-internal
antkmsft Nov 27, 2023
d82ab43
std::cerr => std::cout
antkmsft Nov 28, 2023
c7021b5
Two errors would actually go to stderr
antkmsft Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion samples/integration/vcpkg-all-smoke/src/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

#include <azure/attestation.hpp>
#include <azure/core.hpp>
#include <azure/core/internal/json/json.hpp>
#include <azure/identity.hpp>
#include <azure/keyvault/certificates.hpp>
#include <azure/keyvault/keys.hpp>
Expand Down
4 changes: 0 additions & 4 deletions sdk/attestation/azure-security-attestation/samples/policy/reset_policy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@
*/

#include <azure/attestation.hpp>
#include <azure/core/base64.hpp>
#include <azure/core/cryptography/hash.hpp>
#include <azure/core/internal/cryptography/sha_hash.hpp>
#include <azure/identity.hpp>

#include <chrono>
Expand All @@ -34,7 +31,6 @@ using namespace Azure::Security::Attestation;
using namespace Azure::Security::Attestation::Models;
using namespace std::chrono_literals;
using namespace Azure::Core;
using namespace Azure::Core::Cryptography::_internal;

int main()
{
Expand Down
4 changes: 0 additions & 4 deletions sdk/attestation/azure-security-attestation/samples/policy/reset_sealed_policy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@
#include "cryptohelpers.hpp"

#include <azure/attestation.hpp>
#include <azure/core/base64.hpp>
#include <azure/core/cryptography/hash.hpp>
#include <azure/core/internal/cryptography/sha_hash.hpp>
#include <azure/identity.hpp>

#include <chrono>
Expand All @@ -37,7 +34,6 @@ using namespace Azure::Security::Attestation;
using namespace Azure::Security::Attestation::Models;
using namespace std::chrono_literals;
using namespace Azure::Core;
using namespace Azure::Core::Cryptography::_internal;

int main()
{
Expand Down
2 changes: 1 addition & 1 deletion sdk/attestation/azure-security-attestation/samples/policy/set_policy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
#include <thread>
#include <vector>

// cspell:: words mrsigner mrenclave mitm
// cspell: words mrsigner mitm
using namespace Azure::Security::Attestation;
using namespace Azure::Security::Attestation::Models;
using namespace std::chrono_literals;
Expand Down
16 changes: 4 additions & 12 deletions sdk/eventhubs/azure-messaging-eventhubs/samples/consume-events/consume_events.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,8 @@
// Both of these should be available from the Azure portal.
//

#include <azure/core/diagnostics/logger.hpp>
#include <azure/core/internal/diagnostics/log.hpp>
#include <azure/messaging/eventhubs.hpp>

using namespace Azure::Core::Diagnostics;
using namespace Azure::Core::Diagnostics::_internal;

#include <iostream>

int main()
Expand All @@ -43,7 +38,6 @@ int main()
// Retrieve properties about the EventHubs instance just created.
auto eventhubProperties{consumerClient.GetEventHubProperties()};
std::cout << "Created event hub, properties: " << eventhubProperties << std::endl;
Log::Stream(Logger::Level::Verbose) << "Created event hub, properties: " << eventhubProperties;

// Retrieve properties about the EventHubs instance just created.
auto partitionProperties{
Expand All @@ -57,13 +51,11 @@ int main()
partitionClientOptions.StartPosition.Earliest = true;
partitionClientOptions.StartPosition.Inclusive = true;

Log::Stream(Logger::Level::Verbose)
<< "Creating partition client. Start position: " << partitionClientOptions.StartPosition;
Log::Stream(Logger::Level::Verbose)
<< "Creating partition client. Start position: " << partitionClientOptions.StartPosition;
std::cerr << "Creating partition client. Start position: "
Comment thread
antkmsft marked this conversation as resolved.
Outdated
<< partitionClientOptions.StartPosition;

Log::Stream(Logger::Level::Verbose) << "earliest: HasValue: " << std::boolalpha
<< partitionClientOptions.StartPosition.Earliest.HasValue();
std::cerr << "earliest: HasValue: " << std::boolalpha
<< partitionClientOptions.StartPosition.Earliest.HasValue();
Comment thread
antkmsft marked this conversation as resolved.
Outdated
if (partitionClientOptions.StartPosition.Earliest.HasValue())
{
std::cerr << "earliest: Value: " << std::boolalpha
Expand Down