Only check the touched markdown files in PR for the Verify link step #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 15, 2020
Merged
Merged
Merged
Closed
Closed
Closed
Closed
weshaggard
approved these changes
Oct 15, 2020
weshaggard
reviewed
Oct 16, 2020
| - template: /eng/common/pipelines/templates/steps/verify-links.yml | ||
| parameters: | ||
| Directory: '' | ||
| Urls: (git diff origin/${env:SYSTEM_PULLREQUEST_TARGETBRANCH} HEAD --name-only -- *.md) |
Member
There was a problem hiding this comment.
As we talked in the cpp repo we shouldn't add this logic unless we have an aggregate report type pipeline that we can use to check all the files. For this repo I suspect we should just keep it always checking all the MD files as it is a smaller repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue: Azure/azure-sdk-for-ios#488
Java: Azure/azure-sdk-for-java#16008
.NET: Azure/azure-sdk-for-net#15929
Python: Azure/azure-sdk-for-python#14466
JS: Azure/azure-sdk-for-js#11803
Android: #405
C: Azure/azure-sdk-for-c#1431
CPP: Azure/azure-sdk-for-cpp#787
Go: Azure/azure-sdk-for-go#12809
IOS: Azure/azure-sdk-for-ios#488