Skip to content

Only check the touched markdown files in PR for the Verify link step #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sima-zhu wants to merge 1 commit into from
Closed

Only check the touched markdown files in PR for the Verify link step #405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions eng/pipelines/templates/jobs/archetype-sdk-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,12 @@ jobs:
vmImage: '$(OSVmImage)'

steps:

- template: ../../../common/pipelines/templates/steps/verify-links.yml
parameters:
Directory: ''
CheckLinkGuidance: $true
- ${{ if eq(variables['Build.Reason'], 'PullRequest') }}:
- template: /eng/common/pipelines/templates/steps/verify-links.yml
parameters:
Directory: ''
Urls: (git diff origin/${env:SYSTEM_PULLREQUEST_TARGETBRANCH} HEAD --name-only -- *.md)
Copy link
Member

@weshaggard weshaggard Oct 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we talked in the cpp repo we shouldn't add this logic unless we have an aggregate report type pipeline that we can use to check all the files. For this repo I suspect we should just keep it always checking all the MD files as it is a smaller repo.

CheckLinkGuidance: $true

- script: |
./gradlew sdk:${{parameters.ServiceDirectory}}:lintDebug
Expand Down