Skip to content

Only check the touched markdown files in PR for the Verify link step #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sima-zhu wants to merge 1 commit into from
Closed

Only check the touched markdown files in PR for the Verify link step #1431

sima-zhu wants to merge 1 commit into from

Conversation

@sima-zhu
Copy link
Contributor

@sima-zhu sima-zhu commented Oct 15, 2020 •
edited
Loading

@sima-zhu sima-zhu requested review from a team and danieljurek as code owners October 15, 2020 18:08
@sima-zhu sima-zhu self-assigned this Oct 15, 2020
This was referenced Oct 15, 2020
Closed
Closed
Closed
Closed
Merged
Merged
Merged
Merged
@sima-zhu
Copy link
Contributor Author

sima-zhu commented Oct 20, 2020

The aggregate-report pipeline has to setup for all necessary checking against entire repo. It should take more things into consideration more than link verification. Currently, the light weight solution to address the problem is to scan the entire repo in yml file, which is able to cover all md files. Will close the PR and open another one for covering root readme

@sima-zhu sima-zhu closed this Oct 20, 2020
@sima-zhu sima-zhu deleted the checkOnDiff branch October 20, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weshaggard weshaggard weshaggard approved these changes

@danieljurek danieljurek Awaiting requested review from danieljurek

Assignees

@sima-zhu sima-zhu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sima-zhu @weshaggard