Only check the touched markdown files in PR for the Verify link step #16008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sima-zhu
force-pushed
the
checkLinkOnDiff
branch
3 times, most recently
from
4455fe8 to
d35b6bb
Compare
weshaggard
reviewed
Oct 8, 2020
weshaggard
reviewed
Oct 8, 2020
sima-zhu
requested review from
JimSuplizio,
danieljurek and
mitchdenny
as code owners
sima-zhu
changed the title
sima-zhu
force-pushed
the
checkLinkOnDiff
branch
from
a17d53d to
a980dea
Compare
This was referenced Oct 13, 2020
Merged
weshaggard
reviewed
Oct 13, 2020
Contributor
Author
|
/azp run java - core -ci |
|
No pipelines are associated with this pull request. |
Contributor
Author
|
/azp run java - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sima-zhu
force-pushed
the
checkLinkOnDiff
branch
from
c58e5f2 to
a5a7bb4
Compare
weshaggard
reviewed
Oct 15, 2020
This was referenced Oct 15, 2020
Only check the touched markdown files in PR for the Verify link step
Azure/azure-sdk-for-android#405
Closed
Closed
Closed
Closed
weshaggard
approved these changes
Oct 15, 2020
sima-zhu
force-pushed
the
checkLinkOnDiff
branch
from
59c2b0e to
65e434c
Compare
…into checkLinkOnDiff
sima-zhu
requested review from
a team,
JianpingChen,
RezaJooyandeh and
ankitarorabit
as code owners
sima-zhu
requested review from
weshaggard
and removed request for
a team,
JianpingChen,
JimSuplizio,
RezaJooyandeh,
alzimmermsft,
ankitarorabit,
anuchandy,
danieljurek,
hemanttanwar,
jianghaolu,
mitchdenny and
srnagar
weshaggard
reviewed
Oct 16, 2020
eng/common/scripts/Verify-Links.ps1
Outdated
Member
There was a problem hiding this comment.
I assume this is just for testing?
Contributor
Author
There was a problem hiding this comment.
Yes, it is for testing. Will remove.
I found the script did not pick up HEAD correctly. I have 2 readme changes, but only one got picked up.
git diff origin/master HEAD --name-only -- *.md
I am trying to use commit and test
git diff origin/master "${env:SYSTEM_PULLREQUEST_SOURCECOMMITID}" --name-only -- *.md
6e4ff91 to
ebd1b85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered from PR based on master:
https://dev.azure.com/azure-sdk/public/_build/results?buildId=576322&view=logs&jobId=b70e5e73-bbb6-5567-0939-8415943fadb9&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=bdeefc16-b669-5ebd-ad94-a2c19ade53b0
Triggered from PR based on feature:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=576321&view=logs&jobId=b70e5e73-bbb6-5567-0939-8415943fadb9&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=bdeefc16-b669-5ebd-ad94-a2c19ade53b0
Triggered from ci/manual build:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=576324&view=logs&s=6884a131-87da-5381-61f3-d7acc3b91d76&j=b70e5e73-bbb6-5567-0939-8415943fadb9
Changes in all repos:
Java: #16008
.NET: Azure/azure-sdk-for-net#15929
Python: Azure/azure-sdk-for-python#14466
JS: Azure/azure-sdk-for-js#11803
Android: Azure/azure-sdk-for-android#405
C: Azure/azure-sdk-for-c#1431
CPP: Azure/azure-sdk-for-cpp#787
Go: Azure/azure-sdk-for-go#12809
IOS: Azure/azure-sdk-for-ios#488