-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[DataFactory]Add CompressionCodec property for ORC Dataset #7452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merge from azure master
merge from master
Merge from azure-master
Merge from azure master
In Testing, Please Ignore[Logs] (Generated from 89e4b3f, Iteration 2)
|
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
|
@TinaHu1 Also I failed to find the usage of "OrcDataset" which is affected. Could you specify? |
It has been used by "Dataset" at specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json by using "x-ms-discriminator-value". |
|
What about 1st question? The point is I didn't find it in https://github.com/TinaHu1/azure-rest-api-specs/blob/orccompression/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json. Not sure if I was missing anything or not. If you are sure it is in proper use then it is fine for me. |
It should be "new property added in response", but it can not be simply treated as breaking change in ADF case, please take this PR as reference: #7040, thanks. |
OK. We will do the same ARMFeedback same as that PR. |
KrisBash
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.