Skip to content

[Data Factory] Add Dynamics Server-to-Server authentication type & Add Orc compression codec property.#8433

Merged
isra-fel merged 4 commits intoAzure:masterfrom
sjtuxzq:DynamicsS2S
Oct 26, 2019
Merged

[Data Factory] Add Dynamics Server-to-Server authentication type & Add Orc compression codec property.#8433
isra-fel merged 4 commits intoAzure:masterfrom
sjtuxzq:DynamicsS2S

Conversation

@sjtuxzq
Copy link
Contributor

@sjtuxzq sjtuxzq commented Oct 25, 2019

  1. Add Dynamics Server-to-Server authentication type.
  2. Add Orc compression codec property.

@sjtuxzq sjtuxzq requested a review from erich-wang as a code owner October 25, 2019 07:02
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjtuxzq
Please put your swagger spec review pr link(s) here, and
please update AssemblyInfo.cs too

<PackageId>Microsoft.Azure.Management.DataFactory</PackageId>
<Description>Azure Data Factory V2 is the data integration platform that goes beyond Azure Data Factory V1's orchestration and batch-processing of time-series data, with a general purpose app model supporting modern data warehousing patterns and scenarios, lift-and-shift SSIS, and data-driven SaaS applications. Compose and manage reliable and secure data integration workflows at scale. Use native ADF data connectors and Integration Runtimes to move and transform cloud and on-premises data that can be unstructured, semi-structured, and structured with Hadoop, Azure Data Lake, Spark, SQL Server, Cosmos DB and many other data platforms.</Description>
<Version>4.3.0</Version>
<Version>4.3.1</Version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you follow sementic versioning -- update the minor version if you are adding new features

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.e. 4.4.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isra-fel isra-fel added Mgmt This issue is related to a management package. needs-revision labels Oct 25, 2019
[assembly: AssemblyDescription("Provides management functionality for Microsoft Azure Data Factory Resources.")]
[assembly: AssemblyVersion("4.3.0.0")]
[assembly: AssemblyFileVersion("4.3.0.0")]
[assembly: AssemblyVersion("4.4.0.0")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AssemblyVersion is supposed to be update only when it's a major version update.
I'll change it back to 4.3.0 for you, so that the PR could be merged.

@isra-fel isra-fel merged commit 50de5f3 into Azure:master Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants