Skip to content

[Keyvault] Merging keyvault_preview into master for 7.0 / 2018-02-14 release#3299

Merged
jhendrixMSFT merged 22 commits intomasterfrom
keyvault_preview
Jun 26, 2018
Merged

[Keyvault] Merging keyvault_preview into master for 7.0 / 2018-02-14 release#3299
jhendrixMSFT merged 22 commits intomasterfrom
keyvault_preview

Conversation

@schaabs
Copy link

@schaabs schaabs commented Jun 25, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

Scott Schaab and others added 22 commits February 26, 2018 11:19
[KeyVault] adding new certificate fields and parameters (#2539)
1621825 
* adding new certificate feilds and parameters

* updating CertificateTransparency description based of PR feedback
updating data-plane readme to generate 7.0-preview by default (#2543)
6361910 
* updating data-plane readme to generate 7.0-preview by default

* updating python package-version
@lmazuel
adding nodejs.readme for PR automation (#2569)
b3108e8
[KeyVault] adding version 2018-02-14-preview with Network ACLs (#2538)
026ea65 
* creating rest version 2018-02-14-preview from 2016-10-01

* adding network acls feature

* updating readme.md with version 2018-02-14-preview

* changing default version in the resource manager readme
Mgmt swagger fixes (#2603)
85da396 
* removing errantly added readonly property

* updating python lib version in rm readme.md
@RandalliLama
Add keyvault cert backup (#2685)
b11998f
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …
d62079a 
…into keyvault_preview
@dragav
fixing typo resulting in mis-spelled API name (#2729)
36d131e
@tiffanyachen
Updated Key Vault Java readme's payload flattening threshold and base…
63f5b1a 
… class name (#2583)
@dragav
moving cert_transparency property under IssuerParameters
2a71e43
@dragav
Keyvault preview (#2798)
e964a04 
* fixing typo resulting in mis-spelled API name

* adding missing certificate permissions
Update python package version in data-plane and resource-manager read…
88d09db 
…me (#2803)

* update python package version in data-plane and resource-manager readme

* removing superfluous commas
@daviddesberg
AKV Rest Samples (#2873)
3e114e4 
* REST samples for keyvault APIs
@daviddesberg
fix typos (#3104)
10f36cd
@daviddesberg
Small doc tweaks (#3120)
61d7d4a 
* fix typos

* 3072 and 4096 are valid rsa key sizes

* add ecc descriptions

* Tweak ec descriptions
Adding descriptions to JsonWebKey kty values (#3199)
098a49e
Adding crv to KeyProperties for EC certificate support (#3198)
c9a72aa
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …
264fb29 
…into keyvault_preview
renaming crv secp256k1 and alg ECDSA256 to align with proposed JOSE s…
45eef24 
…tandards updates (#3277)
Moving 7.0 from preview to stable (#3279)
dbef199 
-updating version from 7.0-preview to 7.0
 -updating data-plane readme paths and versions
Moving 2018-02-14 from preview to stable (#3281)
57fd930 
* Moving 2018-02-14 from preview to stable

* fixing path to stable 2018-02-14 swagger files

* updating csharp.md to remove multiapi changes
Restoring the x-ms-client-name property accidently stripped from kty …
e560fd1 
…on KeyProperties (#3288)
@schaabs schaabs requested a review from tiffanyachen June 25, 2018 19:31
@azuresdkci azuresdkci requested a review from dsgouda June 25, 2018 19:32
@AutorestCI AutorestCI mentioned this pull request Jun 25, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 25, 2018 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#2815

@AutorestCI AutorestCI mentioned this pull request Jun 25, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 25, 2018 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3059

@AutorestCI AutorestCI mentioned this pull request Jun 25, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 25, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#1420

@AutorestCI AutorestCI mentioned this pull request Jun 25, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 25, 2018 •
edited
Loading

Automation for azure-sdk-for-java

A PR has been created for you:
Azure/azure-sdk-for-java#2140

@AutorestCI
Copy link

AutorestCI commented Jun 25, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/keyvault/data-plane/readme.md

⚠️0 new Warnings.(0 total)
❌0 new Errors.(0 total)

File: specification/keyvault/resource-manager/readme.md

⚠️0 new Warnings.(8 total)
❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@AutorestCI
Copy link

AutorestCI commented Jun 25, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/keyvault/data-plane/readme.md

⚠️0 new Warnings.(0 total)
❌0 new Errors.(30 total)

File: specification/keyvault/resource-manager/readme.md

⚠️0 new Warnings.(15 total)
❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@AutorestCI AutorestCI mentioned this pull request Jun 25, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 25, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#2122

@dsgouda
Copy link
Contributor

dsgouda commented Jun 26, 2018

Reassigning not very well versed with data plane specs

@azuresdkci azuresdkci assigned sarangan12 and unassigned dsgouda Jun 26, 2018
@azuresdkci azuresdkci requested a review from sarangan12 June 26, 2018 20:03
@jhendrixMSFT
Copy link
Member

jhendrixMSFT commented Jun 26, 2018

Per discussion with @schaabs the commits here were reviewed in their feature branch; this PR is a "git merge" of their feature branch into master.

@jhendrixMSFT jhendrixMSFT merged commit 7741b58 into master Jun 26, 2018
@AutorestCI AutorestCI mentioned this pull request Jun 26, 2018
Closed
@vladbarosan vladbarosan deleted the keyvault_preview branch November 7, 2018 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@dsgouda dsgouda Awaiting requested review from dsgouda

@sarangan12 sarangan12 Awaiting requested review from sarangan12

+1 more reviewer

@tiffanyachen tiffanyachen tiffanyachen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sarangan12 sarangan12

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@schaabs @AutorestCI @dsgouda @jhendrixMSFT @tiffanyachen @sarangan12 @azuresdkci @RandalliLama @dragav @daviddesberg