-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Restoring the x-ms-client-name property accidently stripped from kty … #3288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-pythonEncountered an unknown error: (azure-sdk-for-python)
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 32, in exception_to_github
yield context
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 167, in rest_handle_action
return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 182, in rest_pull_close
rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
sdk_tag=sdk_tag
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 300, in generate_sdk_from_git_object
sdk_repo.git.push('origin', base_branch, set_upstream=True)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
return self.execute(call, **exec_kwargs)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(1)
cmdline: git push --set-upstream origin restapi_auto_keyvault_preview
stderr: 'To https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-python.git
! [rejected] restapi_auto_keyvault_preview -> restapi_auto_keyvault_preview (fetch first)
error: failed to push some refs to 'https://AutorestCI:[email protected]/Azure/azure-sdk-for-python.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.' |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-nodeA PR has been created for you: |
This was referenced Jun 21, 2018
Automation for azure-sdk-for-goA PR has been created for you: |
tiffanyachen
approved these changes
Jun 22, 2018
jhendrixMSFT
pushed a commit
that referenced
this pull request
Jun 26, 2018
…release (#3299) * [KeyVault] adding new certificate fields and parameters (#2539) * adding new certificate feilds and parameters * updating CertificateTransparency description based of PR feedback * updating data-plane readme to generate 7.0-preview by default (#2543) * updating data-plane readme to generate 7.0-preview by default * updating python package-version * adding nodejs.readme for PR automation (#2569) * [KeyVault] adding version 2018-02-14-preview with Network ACLs (#2538) * creating rest version 2018-02-14-preview from 2016-10-01 * adding network acls feature * updating readme.md with version 2018-02-14-preview * changing default version in the resource manager readme * Mgmt swagger fixes (#2603) * removing errantly added readonly property * updating python lib version in rm readme.md * Add keyvault cert backup (#2685) * fixing typo resulting in mis-spelled API name (#2729) * Updated Key Vault Java readme's payload flattening threshold and base class name (#2583) * moving cert_transparency property under IssuerParameters * Keyvault preview (#2798) * fixing typo resulting in mis-spelled API name * adding missing certificate permissions * Update python package version in data-plane and resource-manager readme (#2803) * update python package version in data-plane and resource-manager readme * removing superfluous commas * AKV Rest Samples (#2873) * REST samples for keyvault APIs * fix typos (#3104) * Small doc tweaks (#3120) * fix typos * 3072 and 4096 are valid rsa key sizes * add ecc descriptions * Tweak ec descriptions * Adding descriptions to JsonWebKey kty values (#3199) * Adding crv to KeyProperties for EC certificate support (#3198) * renaming crv secp256k1 and alg ECDSA256 to align with proposed JOSE standards updates (#3277) * Moving 7.0 from preview to stable (#3279) -updating version from 7.0-preview to 7.0 -updating data-plane readme paths and versions * Moving 2018-02-14 from preview to stable (#3281) * Moving 2018-02-14 from preview to stable * fixing path to stable 2018-02-14 swagger files * updating csharp.md to remove multiapi changes * Restoring the x-ms-client-name property accidently stripped from kty on KeyProperties (#3288)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on KeyProperties
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger