Skip to content

Conversation

@schaabs
Copy link

@schaabs schaabs commented Jun 8, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@schaabs schaabs requested a review from RandalliLama June 8, 2018 15:44
@schaabs schaabs requested a review from tiffanyachen as a code owner June 8, 2018 15:44
@bsiegel bsiegel added the review label Jun 8, 2018
@AutorestCI
Copy link

AutorestCI commented Jun 8, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 8, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented Jun 8, 2018

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 32, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 167, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 182, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 300, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', base_branch, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 550, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1009, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 820, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(1)
  cmdline: git push --set-upstream origin restapi_auto_keyvault_preview
  stderr: 'To https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-python.git
 ! [rejected]        restapi_auto_keyvault_preview -> restapi_auto_keyvault_preview (fetch first)
error: failed to push some refs to 'https://AutorestCI:[email protected]/Azure/azure-sdk-for-python.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.'

@AutorestCI
Copy link

AutorestCI commented Jun 8, 2018

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#2958

@AutorestCI
Copy link

AutorestCI commented Jun 8, 2018

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#1994

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/keyvault/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 30
After the PR: Warning(s): 0 Error(s): 30

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

Copy link
Contributor

@RandalliLama RandalliLama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@schaabs schaabs merged commit c9a72aa into Azure:keyvault_preview Jun 8, 2018
jhendrixMSFT pushed a commit that referenced this pull request Jun 26, 2018
…release (#3299)

* [KeyVault] adding new certificate fields and parameters (#2539)

* adding new certificate feilds and parameters

* updating CertificateTransparency description based of PR feedback

* updating data-plane readme to generate 7.0-preview by default (#2543)

* updating data-plane readme to generate 7.0-preview by default

* updating python package-version

* adding nodejs.readme for PR automation (#2569)

* [KeyVault] adding version 2018-02-14-preview with Network ACLs (#2538)

* creating rest version 2018-02-14-preview from 2016-10-01

* adding network acls feature

* updating readme.md with version 2018-02-14-preview

* changing default version in the resource manager readme

* Mgmt swagger fixes (#2603)

* removing errantly added readonly property

* updating python lib version in rm readme.md

* Add keyvault cert backup (#2685)

* fixing typo resulting in mis-spelled API name (#2729)

* Updated Key Vault Java readme's payload flattening threshold and base class name (#2583)

* moving cert_transparency property under IssuerParameters

* Keyvault preview (#2798)

* fixing typo resulting in mis-spelled API name

* adding missing certificate permissions

* Update python package version in data-plane and resource-manager readme (#2803)

* update python package version in data-plane and resource-manager readme

* removing superfluous commas

* AKV Rest Samples (#2873)

* REST samples for keyvault APIs

* fix typos (#3104)

* Small doc tweaks (#3120)

* fix typos

* 3072 and 4096 are valid rsa key sizes

* add ecc descriptions

* Tweak ec descriptions

* Adding descriptions to JsonWebKey kty values (#3199)

* Adding crv to KeyProperties for EC certificate support (#3198)

* renaming crv secp256k1 and alg ECDSA256 to align with proposed JOSE standards updates (#3277)

* Moving 7.0 from preview to stable (#3279)

-updating version from 7.0-preview to 7.0
 -updating data-plane readme paths and versions

* Moving 2018-02-14 from preview to stable (#3281)

* Moving 2018-02-14 from preview to stable

* fixing path to stable 2018-02-14 swagger files

* updating csharp.md to remove multiapi changes

* Restoring the x-ms-client-name property accidently stripped from kty on KeyProperties (#3288)
XiaofeiCao pushed a commit to XiaofeiCao/azure-rest-api-specs that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants