Skip to content

Small doc tweaks#3120

Merged
daviddesberg merged 5 commits intoAzure:keyvault_previewfrom
daviddesberg:feature/kv_preview_doc_updates
May 23, 2018
Merged

Small doc tweaks#3120
daviddesberg merged 5 commits intoAzure:keyvault_previewfrom
daviddesberg:feature/kv_preview_doc_updates

Conversation

@daviddesberg
Copy link
Contributor

Update RSA key size examples. Not sure how to add descriptions to JsonWebKeyCurveName without disrupting API client generation...anyone more experience with swagger feel free to chime in.

@AutorestCI
Copy link

AutorestCI commented May 22, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented May 22, 2018

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#2605

@AutorestCI
Copy link

AutorestCI commented May 22, 2018

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmpmw1zz0o4/rest/specification/keyvault/data-plane/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpiou7d6hb']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4275/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4275)
  Error: Unable to acquire exclusive lock on '_root_.autorest.busy-lock' before timeout 20000 msec.

@AutorestCI
Copy link

AutorestCI commented May 22, 2018

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#1886

@AutorestCI
Copy link

AutorestCI commented May 23, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/keyvault/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 30
After the PR: Warning(s): 0 Error(s): 30

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

1 similar comment
@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/keyvault/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 30
After the PR: Warning(s): 0 Error(s): 30

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

"type": "integer",
"format": "int32",
"description": "The key size in bits. For example; 1024 or 2048."
"description": "The key size in bits. For example: 1024, 2048, 3072, or 4096 for RSA."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove 1024 from these lists, it only applies to imported keys

@daviddesberg daviddesberg merged commit 61d7d4a into Azure:keyvault_preview May 23, 2018
@daviddesberg daviddesberg deleted the feature/kv_preview_doc_updates branch May 23, 2018 21:59
jhendrixMSFT pushed a commit that referenced this pull request Jun 26, 2018
…release (#3299)

* [KeyVault] adding new certificate fields and parameters (#2539)

* adding new certificate feilds and parameters

* updating CertificateTransparency description based of PR feedback

* updating data-plane readme to generate 7.0-preview by default (#2543)

* updating data-plane readme to generate 7.0-preview by default

* updating python package-version

* adding nodejs.readme for PR automation (#2569)

* [KeyVault] adding version 2018-02-14-preview with Network ACLs (#2538)

* creating rest version 2018-02-14-preview from 2016-10-01

* adding network acls feature

* updating readme.md with version 2018-02-14-preview

* changing default version in the resource manager readme

* Mgmt swagger fixes (#2603)

* removing errantly added readonly property

* updating python lib version in rm readme.md

* Add keyvault cert backup (#2685)

* fixing typo resulting in mis-spelled API name (#2729)

* Updated Key Vault Java readme's payload flattening threshold and base class name (#2583)

* moving cert_transparency property under IssuerParameters

* Keyvault preview (#2798)

* fixing typo resulting in mis-spelled API name

* adding missing certificate permissions

* Update python package version in data-plane and resource-manager readme (#2803)

* update python package version in data-plane and resource-manager readme

* removing superfluous commas

* AKV Rest Samples (#2873)

* REST samples for keyvault APIs

* fix typos (#3104)

* Small doc tweaks (#3120)

* fix typos

* 3072 and 4096 are valid rsa key sizes

* add ecc descriptions

* Tweak ec descriptions

* Adding descriptions to JsonWebKey kty values (#3199)

* Adding crv to KeyProperties for EC certificate support (#3198)

* renaming crv secp256k1 and alg ECDSA256 to align with proposed JOSE standards updates (#3277)

* Moving 7.0 from preview to stable (#3279)

-updating version from 7.0-preview to 7.0
 -updating data-plane readme paths and versions

* Moving 2018-02-14 from preview to stable (#3281)

* Moving 2018-02-14 from preview to stable

* fixing path to stable 2018-02-14 swagger files

* updating csharp.md to remove multiapi changes

* Restoring the x-ms-client-name property accidently stripped from kty on KeyProperties (#3288)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants