-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Release app microsoft.app 2024 02 02 preview #29312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release app microsoft.app 2024 02 02 preview #29312
Conversation
…preview to version 2024-02-02-preview
* Functions extension api-spec commit * merge with latest * Functions Extension in 2024-02-02-preview * correcetd version in readme * avacado fail fix - version * pattern addition * fix for PathForResourceAction * lint diff and model validation checks * AutoRest exception fix * endpoint response as string and not schema * response schema with string * example schema * example within spec * extension example with data * extensions example with body * body as string
* add configuration.runtime for apps
* Add Nacos For Java Component. * fix spell check.
* [Container Apps] Update Runtime to add DotNet support * Remove default value * Rename dotNet to dotnet
…ent (Azure#28005) * [Container Apps] Remove AspireResourceServerApi type for DotNetComponent * Only keep changes to 2024-02-02-preview
…ba and eureka (Azure#28102) * Make the JavaComponent definitions polymorphism * fix api version * revert error response change * refine examples * fix default value * fix * fix * try to remove required * try remove require in patch body * fix * try fix lint * fix * add suppression for discriminator * fix --------- Co-authored-by: Xuyang Cao <[email protected]>
* Added CloudBuild and CloudPatch * Fixed pipeline errors * Added ContainerApp example * Fixed typo in example * Fixed linting error * Fixed spacing * Addressed comments * Addressed comments and modified sample * Fixed linting error * Addressed comments * Linting * Fixed typo * Fixed Typo * Resolving model validation error
* add java agent related properties * fix build error * fix format * re-run pipeline * update enum list and fix typo * revert cspell config * update level field type from enum to string * add identifiers for array prop
* fix * fix
* Adding identity for scale rules * fix scale example
* fix * fix * fix * fix * fix * fix
* Add detailed job execution to api * Add fields * address comment * add x-ms-identifiers * prettier * address comments * Address comments * Address comments * update example * Fix property name * Fix example
* optimize java agent related props * fix * adding logging property to include logger settings --------- Co-authored-by: Bowen Wan <[email protected]>
* add accountName for queueScaler * updated example * updated * updated * updated
* Adding identity settings * fix casing in examples * Switch to array since ARM doesn't allow dictionaries. * identity property should be required. * prettier * Updating description * Adding Jobs spec * Update specification/app/resource-manager/Microsoft.App/preview/2024-02-02-preview/Jobs.json Co-authored-by: Jitin John <[email protected]> * Move IdentitySettings to CommonDefinitions --------- Co-authored-by: Jitin John <[email protected]>
* Add SessionPools.json and Sessions.json
* add pe * fix * fix * fix * fix * fix * fix * use v5 * fix * fix
* Add support for SMB storage in connectedEnvironment * move smb properties to common * fix reference --------- Co-authored-by: [email protected] <[email protected]>
* API spec for LogicApps extension on Microsoft.App * format * fix typos * fix issues * fix example references * fix more issues * fix issues * fix more model validation * fix * fix model * fix format * fix lintdiff * fix example * fix headers * add delete * add missing file --------- Co-authored-by: Anand G Menon <[email protected]>
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
| Compared specs (v0.10.9) | new version | base version |
|---|---|---|
| AppResiliency.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| AuthConfigs.json | 2024-02-02-preview(f4e6dbc) | 2023-05-01(main) |
| AuthConfigs.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| AvailableWorkloadProfiles.json | 2024-02-02-preview(f4e6dbc) | 2023-05-01(main) |
| AvailableWorkloadProfiles.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| BillingMeters.json | 2024-02-02-preview(f4e6dbc) | 2023-05-01(main) |
| BillingMeters.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| Builders.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| Builds.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| CommonDefinitions.json | 2024-02-02-preview(f4e6dbc) | 2023-05-01(main) |
| CommonDefinitions.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| ConnectedEnvironments.json | 2024-02-02-preview(f4e6dbc) | 2023-05-01(main) |
| ConnectedEnvironments.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| ConnectedEnvironmentsCertificates.json | 2024-02-02-preview(f4e6dbc) | 2023-05-01(main) |
| ConnectedEnvironmentsCertificates.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| ConnectedEnvironmentsDaprComponents.json | 2024-02-02-preview(f4e6dbc) | 2023-05-01(main) |
| ConnectedEnvironmentsDaprComponents.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| ConnectedEnvironmentsStorages.json | 2024-02-02-preview(f4e6dbc) | 2023-05-01(main) |
| ConnectedEnvironmentsStorages.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| ContainerApps.json | 2024-02-02-preview(f4e6dbc) | 2023-05-01(main) |
| ContainerApps.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| ContainerAppsRevisions.json | 2024-02-02-preview(f4e6dbc) | 2023-05-01(main) |
| ContainerAppsRevisions.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| Diagnostics.json | 2024-02-02-preview(f4e6dbc) | 2023-05-01(main) |
| Diagnostics.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| DotNetComponents.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| Global.json | 2024-02-02-preview(f4e6dbc) | 2023-05-01(main) |
| Global.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| JavaComponents.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| Jobs.json | 2024-02-02-preview(f4e6dbc) | 2023-05-01(main) |
| Jobs.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| ManagedEnvironments.json | 2024-02-02-preview(f4e6dbc) | 2023-05-01(main) |
| ManagedEnvironments.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| ManagedEnvironmentsDaprComponentResiliencyPolicies.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| ManagedEnvironmentsDaprComponents.json | 2024-02-02-preview(f4e6dbc) | 2023-05-01(main) |
| ManagedEnvironmentsDaprComponents.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| ManagedEnvironmentsDaprSubscriptions.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| ManagedEnvironmentsStorages.json | 2024-02-02-preview(f4e6dbc) | 2023-05-01(main) |
| ManagedEnvironmentsStorages.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| SourceControls.json | 2024-02-02-preview(f4e6dbc) | 2023-05-01(main) |
| SourceControls.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| Subscriptions.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
| Usages.json | 2024-02-02-preview(f4e6dbc) | 2023-11-02-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 17 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with the latest preview version:
Only 17 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 4 Errors, 59 Warnings failed [Detail]
| Compared specs (v2.2.2) | new version | base version |
|---|---|---|
| package-preview-2024-02 | package-preview-2024-02(f4e6dbc) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 17 items are listed, please refer to log for more details.
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:type. Location: Microsoft.App/preview/2024-02-02-preview/Builders.json#L246 |
RPC-Patch-V1-10 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L1194 |
RPC-Policy-V1-05, RPC-Put-V1-23 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L1678 |
RPC-Policy-V1-05, RPC-Put-V1-23 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:type. Location: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L286 |
RPC-Patch-V1-10 |
| A nested resource type's List operation must include all the parent segments in its api path. Location: Microsoft.App/preview/2024-02-02-preview/AppResiliency.json#L260 |
RPC-Get-V1-11 | |
| Use the latest version v5 of managedidentity.json. Location: Microsoft.App/preview/2024-02-02-preview/Builders.json#L377 |
||
| Use the latest version v5 of managedidentity.json. Location: Microsoft.App/preview/2024-02-02-preview/Builders.json#L413 |
||
| A nested resource type's List operation must include all the parent segments in its api path. Location: Microsoft.App/preview/2024-02-02-preview/Builds.json#L36 |
RPC-Get-V1-11 | |
| OperationId should contain the verb: 'listauthtoken' in:'BuildAuthToken_List'. Consider updating the operationId Location: Microsoft.App/preview/2024-02-02-preview/Builds.json#L253 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L1214 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L766 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L917 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L921 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L925 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L929 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L933 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L954 |
The following errors/warnings exist before current PR submission:
Only 17 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
ResourceNameRestriction |
The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2024-02-02-preview/AuthConfigs.json#L18 |
ResourceNameRestriction |
The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2024-02-02-preview/AuthConfigs.json#L67 |
ResourceNameRestriction |
The resource name parameter 'authConfigName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2024-02-02-preview/AuthConfigs.json#L67 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.App/preview/2024-02-02-preview/AuthConfigs.json#L119 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/AuthConfigs.json#L555 |
DefinitionsPropertiesNamesCamelCase |
Property name should be camel case. Location: Microsoft.App/preview/2024-02-02-preview/AuthConfigs.json#L601 |
XmsPageableForListCalls |
x-ms-pageable extension must be specified for LIST APIs.Location: Microsoft.App/preview/2024-02-02-preview/BillingMeters.json#L16 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.App/preview/2024-02-02-preview/BillingMeters.json#L37 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L310 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L473 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L522 |
ResourceNameRestriction |
The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2024-02-02-preview/ConnectedEnvironments.json#L100 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2024-02-02-preview/ConnectedEnvironments.json#L198 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.App/preview/2024-02-02-preview/ConnectedEnvironments.json#L208 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2024-02-02-preview/ConnectedEnvironments.json#L255 |
ResourceNameRestriction |
The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2024-02-02-preview/ConnectedEnvironments.json#L311 |
ResourceNameRestriction |
The resource name parameter 'connectedEnvironmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2024-02-02-preview/ConnectedEnvironmentsCertificates.json#L18 |
️❌Avocado: 1 Errors, 1 Warnings failed [Detail]
| Rule | Message |
|---|---|
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.App/connectedEnvironments/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/app/resource-manager/readme.md json: Microsoft.App/preview/2022-06-01-preview/ConnectedEnvironments.json |
| The JSON file has a circular reference. readme: specification/app/resource-manager/readme.md json: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
Please check the errors reported by the required checks. |
@ms-bogdan-rotaru As I mentioned before, I think there are false alarm. In addition, all commits are reviewed and get arm signed off. |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Thanks for your reply.
|
|
@ms-bogdan-rotaru Thanks for approving the lint issue. For arm review, you can see all related PRs for commits in my PR get arm signed off. |
|
/pr RequestMerge |

ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.