Skip to content

Add private endpoint connections for managed environment#28775

Merged
Juliehzl merged 12 commits intoAzure:release-app-Microsoft.App-2024-02-02-previewfrom
Juliehzl:user/zuh/pe
May 6, 2024
Merged

Add private endpoint connections for managed environment#28775
Juliehzl merged 12 commits intoAzure:release-app-Microsoft.App-2024-02-02-previewfrom
Juliehzl:user/zuh/pe

Conversation

@Juliehzl
Copy link
Contributor

@Juliehzl Juliehzl commented Apr 21, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@openapi-pipeline-app
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

@Juliehzl Juliehzl changed the base branch from main to release-app-Microsoft.App-2024-02-02-preview April 21, 2024 14:01
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 21, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 21, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 33 Errors, 36 Warnings failed [Detail]
Compared specs (v0.10.8) new version base version
CommonDefinitions.json 2024-02-02-preview(eb67b93) 2023-05-01(main)
CommonDefinitions.json 2024-02-02-preview(eb67b93) 2023-11-02-preview(main)
ManagedEnvironments.json 2024-02-02-preview(eb67b93) 2023-05-01(main)
ManagedEnvironments.json 2024-02-02-preview(eb67b93) 2023-11-02-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Only 30 items are listed, please refer to log for more details.

Rule Message
1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: common-types/resource-management/v5/types.json#L204:9
Old: common-types/resource-management/v3/types.json#L204:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: common-types/resource-management/v5/types.json#L210:9
Old: common-types/resource-management/v3/types.json#L209:9
1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L26:9
Old: Microsoft.App/stable/2023-05-01/ManagedEnvironments.json#L26:9
1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L66:9
Old: Microsoft.App/stable/2023-05-01/ManagedEnvironments.json#L66:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L109:9
Old: Microsoft.App/stable/2023-05-01/ManagedEnvironments.json#L109:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L154:9
Old: Microsoft.App/stable/2023-05-01/ManagedEnvironments.json#L154:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L218:9
Old: Microsoft.App/stable/2023-05-01/ManagedEnvironments.json#L218:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L267:9
Old: Microsoft.App/stable/2023-05-01/ManagedEnvironments.json#L267:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L327:9
Old: Microsoft.App/stable/2023-05-01/ManagedEnvironments.json#L327:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L377:9
Old: Microsoft.App/stable/2023-05-01/ManagedEnvironments.json#L377:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L429:9
Old: Microsoft.App/stable/2023-05-01/ManagedEnvironments.json#L429:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L492:9
Old: Microsoft.App/stable/2023-05-01/ManagedEnvironments.json#L489:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L545:9
Old: Microsoft.App/stable/2023-05-01/ManagedEnvironments.json#L542:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L608:9
Old: Microsoft.App/stable/2023-05-01/ManagedEnvironments.json#L605:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L660:9
Old: Microsoft.App/stable/2023-05-01/ManagedEnvironments.json#L657:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L734:9
Old: Microsoft.App/stable/2023-05-01/ManagedEnvironments.json#L731:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L787:9
Old: Microsoft.App/stable/2023-05-01/ManagedEnvironments.json#L784:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L850:9
Old: Microsoft.App/stable/2023-05-01/ManagedEnvironments.json#L847:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L900:9
Old: Microsoft.App/stable/2023-05-01/ManagedEnvironments.json#L897:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L959:9
Old: Microsoft.App/stable/2023-05-01/ManagedEnvironments.json#L956:9
1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9


The following breaking changes are detected by comparison with the latest preview version:

Only 30 items are listed, please refer to log for more details.

Rule Message
⚠️ 1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: common-types/resource-management/v5/types.json#L204:9
Old: common-types/resource-management/v3/types.json#L204:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: common-types/resource-management/v5/types.json#L210:9
Old: common-types/resource-management/v3/types.json#L209:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L26:9
Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L26:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L66:9
Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L66:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L109:9
Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L109:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L154:9
Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L154:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L218:9
Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L218:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L267:9
Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L267:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L327:9
Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L327:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L377:9
Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L377:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L429:9
Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L429:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L492:9
Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L492:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L545:9
Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L545:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L608:9
Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L608:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L660:9
Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L660:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L734:9
Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L734:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L787:9
Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L787:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L850:9
Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L850:9
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-preview-2024-02 package-preview-2024-02(eb67b93) package-preview-2024-02(release-app-Microsoft.App-2024-02-02-preview)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L310
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L473
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L522
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L596
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L596
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L596
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L617
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L621
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L625
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L705
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L705
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L705
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L722
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L1146
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L1193
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json#L1638
ResourceNameRestriction The resource name parameter 'environmentName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L101
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L197
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L211
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L240
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L249
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:type.
Location: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L286
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:location.
Location: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L286
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L301
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L307
ResourceNameRestriction The resource name parameter 'environmentName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L319
ResourceNameRestriction The resource name parameter 'environmentName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L369
ResourceNameRestriction The resource name parameter 'certificateName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L369
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L422
ResourceNameRestriction The resource name parameter 'environmentName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-02-02-preview/ManagedEnvironments.json#L600
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 21, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning in generating from afebf2c3d49159dd0b5b12361fd73f91ab714e44. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh]
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0
    cmderr	[automation_init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0>
    cmderr	[automation_init.sh] npm notice Run `npm install -g npm@10.7.0` to update!
    cmderr	[automation_init.sh] npm notice
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-appcontainers [Preview SDK Changes]
    • azure-mgmt-appcontainers-1.0.0b1.zip
    • azure_mgmt_appcontainers-1.0.0b1-py3-none-any.whl
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from afebf2c3d49159dd0b5b12361fd73f91ab714e44. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-appcontainers [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-appcontainers-1.0.0-beta.8-sources.jar
    • azure-resourcemanager-appcontainers-1.0.0-beta.8.jar
️❌ azure-sdk-for-go failed [Detail]
  • Code Generator Failed in generating from afebf2c3d49159dd0b5b12361fd73f91ab714e44. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    cmderr	[generator automation-v2] [ERROR] total 1 error(s):
    cmderr	[generator automation-v2] [ERROR] failed to execute `go generate` 'WARNING: Unable to find version for /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/appcontainers/armappcontainers
    cmderr	[generator automation-v2] [ERROR] Cannot find go module under resourcemanager/appcontainers/armappcontainers, try to build in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/appcontainers/armappcontainers
    cmderr	[generator automation-v2] [ERROR] ##[command]Cleaning auto-generated files in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/appcontainers/armappcontainers
    cmderr	[generator automation-v2] [ERROR] ##[command]Executing autorest.go in  /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/appcontainers/armappcontainers
    cmderr	[generator automation-v2] [ERROR] autorest --use=@autorest/go@4.0.0-preview.63 --go --track2 --output-folder=/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/appcontainers/armappcontainers --clear-output-folder=false --go.clear-output-folder=false --honor-body-placement=true --remove-unreferenced-types=false ./autorest.md
    cmderr	[generator automation-v2] [ERROR] AutoRest code generation utility [cli version: 3.6.1; node: v18.20.2]
    cmderr	[generator automation-v2] [ERROR] (C) 2018 Microsoft Corporation.
    cmderr	[generator automation-v2] [ERROR] https://aka.ms/autorest
    cmderr	[generator automation-v2] [ERROR] There is a new version of AutoRest available (3.7.1).
    cmderr	[generator automation-v2] [ERROR] > You can install the newer version with with npm install -g autorest@latest
    cmderr	[generator automation-v2] [ERROR] info    |    Loading AutoRest core      '/home/cloudtest/.autorest/@autorestcore@3.10.2/nodemodules/@autorest/core/dist' (3.10.2)
    cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future.
    cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.1.suppress which is deprecated and will be removed in the future.
    cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future.
    cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.1.suppress which is deprecated and will be removed in the future.
    cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.2.suppress which is deprecated and will be removed in the future.
    cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future.
    cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.1.suppress which is deprecated and will be removed in the future.
    cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future.
    cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.1.suppress which is deprecated and will be removed in the future.
    cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future.
    cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.1.suppress which is deprecated and will be removed in the future.
    cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.2.suppress which is deprecated and will be removed in the future.
    cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.3.suppress which is deprecated and will be removed in the future.
    cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.4.suppress which is deprecated and will be removed in the future.
    cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.5.suppress which is deprecated and will be removed in the future.
    cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.6.suppress which is deprecated and will be removed in the future.
    cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.7.suppress which is deprecated and will be removed in the future.
    cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.8.suppress which is deprecated and will be removed in the future.
    cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.9.suppress which is deprecated and will be removed in the future.
    cmderr	[generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.10.suppress which is deprecated and will be removed in the future.
    cmderr	[generator automation-v2] [ERROR] info    |    Installing AutoRest extension '@autorest/go' (4.0.0-preview.63 -> 4.0.0-preview.63)
    cmderr	[generator automation-v2] [ERROR] info    |    Installed AutoRest extension '@autorest/go' (4.0.0-preview.63->4.0.0-preview.63)
    cmderr	[generator automation-v2] [ERROR] info    |    Installing AutoRest extension '@autorest/modelerfour' (4.26.2 -> 4.26.2)
    cmderr	[generator automation-v2] [ERROR] info    |    Installed AutoRest extension '@autorest/modelerfour' (4.26.2->4.26.2)
    cmderr	[generator automation-v2] [ERROR] warning | IgnoredPropertyNextToRef | Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > DaprComponentServiceBinding > properties > metadata)
    cmderr	[generator automation-v2] [ERROR] keys: [ 'type' ]
    cmderr	[generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2024-02-02-preview/CommonDefinitions.json:932:9
    cmderr	[generator automation-v2] [ERROR] warning | IgnoredPropertyNextToRef | Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > JavaComponent > properties > properties)
    cmderr	[generator automation-v2] [ERROR] keys: [ 'type' ]
    cmderr	[generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2024-02-02-preview/JavaComponents.json:401:9
    cmderr	[generator automation-v2] [ERROR] warning | IgnoredPropertyNextToRef | Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > Resource > properties > systemData)
    cmderr	[generator automation-v2] [ERROR] keys: [ 'type' ]
    cmderr	[generator automation-v2] [ERROR] warning | PreCheck/CheckDuplicateSchemas | Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
    cmderr	[generator automation-v2] [ERROR] error   | PreCheck/DuplicateSchema | Duplicate Schema named 'Secret' (2 differences):
    cmderr	[generator automation-v2] [ERROR] - properties.identity: {"$ref":"#/components/schemas/schemas:294","description":"Resource ID of a managed identity to authenticate with Azure Key Vault, or System to use a system-assigned identity."} => <none>
    cmderr	[generator automation-v2] [ERROR] - properties.keyVaultUrl: {"$ref":"#/components/schemas/schemas:295","description":"Azure Key Vault URL pointing to the secret referenced by the container app."} => <none>; This error can be *temporarily* avoided by using the 'modelerfour.lenient-model-deduplication' setting.  NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that.
    cmderr	[generator automation-v2] [ERROR] error   | PreCheck/DuplicateSchema | Duplicate Schema named 'Resource' (3 differences):
    cmderr	[generator automation-v2] [ERROR] - properties.id.$ref: "#/components/schemas/schemas:1246" => "#/components/schemas/schemas:1344"
    cmderr	[generator automation-v2] [ERROR] - properties.id.description: "Fully qualified resource ID for the resource. E.g. \"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{resourceType}/{resourceName}\"" => "Fully qualified resource ID for the resource. Ex - /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{resourceType}/{resourceName}"
    cmderr	[generator automation-v2] [ERROR] - properties.systemData.type: <none> => "object"; This error can be *temporarily* avoided by using the 'modelerfour.lenient-model-deduplication' setting.  NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that.
    cmderr	[generator automation-v2] [ERROR] error   | PreCheck/DuplicateSchema | Duplicate Schema named 'ProxyResource' (1 differences):
    cmderr	[generator automation-v2] [ERROR] - allOf.0.$ref: "#/components/schemas/schemas:1245" => "#/components/schemas/schemas:1343"; This error can be *temporarily* avoided by using the 'modelerfour.lenient-model-deduplication' setting.  NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that.
    cmderr	[generator automation-v2] [ERROR] fatal   | Error: 3 errors occured -- cannot continue.
    cmderr	[generator automation-v2] [ERROR] fatal   | Process() cancelled due to failure
    cmderr	[generator automation-v2] [ERROR] error   |   Error: Plugin prechecker reported failure.
    cmderr	[generator automation-v2] [ERROR] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
    cmderr	[generator automation-v2] [ERROR] ##[error]Error running autorest.go
    cmderr	[generator automation-v2] [ERROR] build.go:5: running "pwsh": exit status 1
    cmderr	[generator automation-v2] [ERROR] ': exit status 1
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2
    warn	Skip package processing as generation is failed
️🔄 azure-sdk-for-js inProgress [Detail]
️❌ azure-resource-manager-schemas failed [Detail]
  • Failed in generating from afebf2c3d49159dd0b5b12361fd73f91ab714e44. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh]  notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.7.0` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  • app/resource-manager [Preview Schema Changes]
️️✔️ azure-powershell succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from afebf2c3d49159dd0b5b12361fd73f91ab714e44. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ️✔️Az.app.DefaultTag [Preview SDK Changes]
    • Az.ContainerAppsApi.0.1.0.nupkg
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 21, 2024

@openapi-pipeline-app
Copy link

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⌛Breaking Change(Cross-Version) pending [Detail]
️⌛LintDiff pending [Detail]
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️⌛SwaggerAPIView pending [Detail]
️⌛TypeSpecAPIView pending [Detail]
️⌛ModelValidation pending [Detail]
️⌛SemanticValidation pending [Detail]
️⌛SpellCheck pending [Detail]
️⌛PR Summary pending [Detail]
️⌛Automated merging requirements met pending [Detail]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

Swagger Generation Artifacts

️🔄ApiDocPreview inProgress [Detail]
️⌛ azure-sdk-for-python-track2 pending [Detail]
️⌛ azure-sdk-for-java pending [Detail]
️⌛ azure-sdk-for-go pending [Detail]
️⌛ azure-sdk-for-js pending [Detail]
️⌛ azure-resource-manager-schemas pending [Detail]
Posted by Swagger Pipeline | How to fix these errors?

"ManagedEnvironments",
"PrivateEndpointConnections"
],
"summary": "Update the state of a private endpoint connection for a given managed environment.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create or Update?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be Update only because the creation of the resource is from private endpoint creation. The Put operation on private endpoint connection only can change its status.

@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 26, 2024
@Juliehzl
Copy link
Contributor Author

/pr RequestMerge

@TimLovellSmith
Copy link
Member

@Juliehzl Very sorry to revisit an already approved PR, but I think we need to move towards making better use of common-types for private links, for maintainability reasons.

Can you please look at all your definitions of

"PrivateEndpoint"
"PrivateEndpointConnection"
"PrivateEndpointConnectionProperties"
"PrivateLinkServiceConnectionState"
"PrivateEndpointServiceConnectionStatus"

and see whether they can be defined by referring to common-types definitions instead?

https://github.com/Azure/azure-rest-api-specs/blob/06e0a7f0657aee8c4bc3face587027d66917f6dd/specification/common-types/resource-management/v6/privatelinks.json

  • or perhaps the v5 version, if that is any closer to yours?
    For any type definitions you can't do that way, I'd like to understand more about what the blocking issues are.

Hopefully this is a relatively straightforward change to author - validating it may be a little more work, but I think it is better to uncover any issues now.

@openapi-workflow-bot
Copy link

This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
Learn more at aka.ms/azsdk/pr-arm-review.

@Juliehzl
Copy link
Contributor Author

@Juliehzl Very sorry to revisit an already approved PR, but I think we need to move towards making better use of common-types for private links, for maintainability reasons.

Can you please look at all your definitions of

"PrivateEndpoint" "PrivateEndpointConnection" "PrivateEndpointConnectionProperties" "PrivateLinkServiceConnectionState" "PrivateEndpointServiceConnectionStatus"

and see whether they can be defined by referring to common-types definitions instead?

https://github.com/Azure/azure-rest-api-specs/blob/06e0a7f0657aee8c4bc3face587027d66917f6dd/specification/common-types/resource-management/v6/privatelinks.json

  • or perhaps the v5 version, if that is any closer to yours?
    For any type definitions you can't do that way, I'd like to understand more about what the blocking issues are.

Hopefully this is a relatively straightforward change to author - validating it may be a little more work, but I think it is better to uncover any issues now.

@TimLovellSmith I do not want to use common type because we have different values for some properties. Please merge it asap. We are urgent to release before build.

@Juliehzl Juliehzl added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 30, 2024
@openapi-workflow-bot openapi-workflow-bot bot removed ARMChangesRequested ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Apr 30, 2024
@TimLovellSmith
Copy link
Member

I do not want to use common type because we have different values for some properties. Please merge it asap. We are urgent to release before build.

I'm sorry but I want the full details - which properties are a problem?

@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 30, 2024
@Juliehzl
Copy link
Contributor Author

Juliehzl commented May 2, 2024

I do not want to use common type because we have different values for some properties. Please merge it asap. We are urgent to release before build.

I'm sorry but I want the full details - which properties are a problem?

For example, the PrivateEndpointConnectionProvisioningState is different.

@Juliehzl Juliehzl added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 2, 2024
@TimLovellSmith TimLovellSmith added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMChangesRequested labels May 2, 2024
@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 2, 2024
@Juliehzl
Copy link
Contributor Author

Juliehzl commented May 2, 2024

/pr RequestMerge

@AzureRestAPISpecReview AzureRestAPISpecReview removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 2, 2024
@Juliehzl Juliehzl enabled auto-merge (squash) May 6, 2024 02:14
@Juliehzl Juliehzl merged commit 9d051b4 into Azure:release-app-Microsoft.App-2024-02-02-preview May 6, 2024
Juliehzl added a commit to Juliehzl/azure-rest-api-specs that referenced this pull request Jun 4, 2024
* add pe

* fix

* fix

* fix

* fix

* fix

* fix

* use v5

* fix

* fix
mentat9 pushed a commit that referenced this pull request Jun 17, 2024
* Adds base for updating Microsoft.App from version preview/2023-11-02-preview to version 2024-02-02-preview

* Updates readme

* Updates API version in new specs and examples

* Functions Extension endpoint for Web RP (#27873)

* Functions extension api-spec commit

* merge with latest

* Functions Extension in 2024-02-02-preview

* correcetd version in readme

* avacado fail fix - version

* pattern addition

* fix for PathForResourceAction

* lint diff and model validation checks

* AutoRest exception fix

* endpoint response as string and not schema

* response schema with string

* example schema

* example within spec

* extension example with data

* extensions example with body

* body as string

* [Microsoft.App] add runtime attribute to app configuration (#27892)

* add configuration.runtime for apps

* Add Nacos For Java Component. (#28045)

* Add Nacos For Java Component.

* fix spell check.

* [Container Apps] Update Runtime to add DotNet support (#28001)

* [Container Apps] Update Runtime to add DotNet support

* Remove default value

* Rename dotNet to dotnet

* [Container Apps] Remove AspireResourceServerApi type for DotNetComponent (#28005)

* [Container Apps] Remove AspireResourceServerApi type for DotNetComponent

* Only keep changes to 2024-02-02-preview

* [ContainerApp] Support peer traffic encryption. (#28129)

* Make the JavaComponent definitions polymorphism and expose fqdn for sba and eureka (#28102)

* Make the JavaComponent definitions polymorphism

* fix api version

* revert error response change

* refine examples

* fix default value

* fix

* fix

* try to remove required

* try remove require in patch body

* fix

* try fix lint

* fix

* add suppression for discriminator

* fix

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* ContainerAppsBuild and ContainerAppsPatch API (#27982)

* Added CloudBuild and CloudPatch

* Fixed pipeline errors

* Added ContainerApp example

* Fixed typo in example

* Fixed linting error

* Fixed spacing

* Addressed comments

* Addressed comments and modified sample

* Fixed linting error

* Addressed comments

* Linting

* Fixed typo

* Fixed Typo

* Resolving model validation error

* [Microsoft.App] add java agent related properties (#28192)

* add java agent related properties

* fix build error

* fix format

* re-run pipeline

* update enum list and fix typo

* revert cspell config

* update level field type from enum to string

* add identifiers for array prop

* Fix error response for aca (#28425)

* fix

* fix

* Adding identity for scale rules (#28283)

* Adding identity for scale rules

* fix scale example

* Fix schema issue for Microsoft.App in 2024-02-02-preview (#28454)

* fix

* fix

* fix

* fix

* fix

* fix

* Update Container Apps Swagger Schema to include kind property  (#28405)

* Added support for KIND property to container apps schema

* added reference to example request schema

* prettier check

* changes to example conforming to swagger

* used enum for app kind

* minor fixes

* merged main

* Revert "merged main"

This reverts commit 2437d60.

* fixed checks

* Add detailed job execution to api (#27977)

* Add detailed job execution to api

* Add fields

* address comment

* add x-ms-identifiers

* prettier

* address comments

* Address comments

* Address comments

* update example

* Fix property name

* Fix example

* [Microsoft.App] optimize java agent related properties (#28573)

* optimize java agent related props

* fix

* adding logging property to include logger settings

---------

Co-authored-by: Bowen Wan <bowan@microsoft.com>

* Add accountName for queueScaler (#28672)

* add accountName for queueScaler

* updated example

* updated

* updated

* updated

* Adding identity settings (#28117)

* Adding identity settings

* fix casing in examples

* Switch to array since ARM doesn't allow dictionaries.

* identity property should be required.

* prettier

* Updating description

* Adding Jobs spec

* Update specification/app/resource-manager/Microsoft.App/preview/2024-02-02-preview/Jobs.json

Co-authored-by: Jitin John <jijohn@microsoft.com>

* Move IdentitySettings to CommonDefinitions

---------

Co-authored-by: Jitin John <jijohn@microsoft.com>

* Add SessionPools and Sessions (#28047)

* Add SessionPools.json and Sessions.json

* Add private endpoint connections for managed environment (#28775)

* add pe

* fix

* fix

* fix

* fix

* fix

* fix

* use v5

* fix

* fix

* Add support for SMB storage in connectedEnvironment (#29158)

* Add support for SMB storage in connectedEnvironment

* move smb properties to common

* fix reference

---------

Co-authored-by: anandgmenon02@gmail.com <anandgmenon@microsoft.com>

* API spec for LogicApps extension on Microsoft.App (#29083)

* API spec for LogicApps extension on Microsoft.App

* format

* fix typos

* fix issues

* fix example references

* fix more issues

* fix issues

* fix more model validation

* fix

* fix model

* fix format

* fix lintdiff

* fix example

* fix headers

* add delete

* add missing file

---------

Co-authored-by: Anand G Menon <anandgmenon@microsoft.com>

* Add publicNetworkAccess in managed environment (#29092)

* fix

* fix

* fix example

* fix lint

* revert previous change for patch

* fix go sdk duplicate schema

* fix go sdk duplicate schema

* fix billing meter

* fix billing meter

---------

Co-authored-by: Jitin John <jijohn@microsoft.com>
Co-authored-by: SushmithaVReddy <sushmithavangala@gmail.com>
Co-authored-by: sonwan2020 <sonwan@microsoft.com>
Co-authored-by: Xiangyang Yu <yyddxxmm@gmail.com>
Co-authored-by: daniv-msft <48293037+daniv-msft@users.noreply.github.com>
Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Harry Li <110055355+harryli0108@users.noreply.github.com>
Co-authored-by: Jimmy Fang <fangjian0423@gmail.com>
Co-authored-by: Vaclav Turecek <vturecek@microsoft.com>
Co-authored-by: Shubham Sachdeva <114050289+Shubhrmcf-07@users.noreply.github.com>
Co-authored-by: lihaMSFT <liha@microsoft.com>
Co-authored-by: Bowen Wan <bowan@microsoft.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: anandgmenon <anandgmenon02@gmail.com>
Co-authored-by: anandgmenon02@gmail.com <anandgmenon@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants