[Microsoft.App] add runtime attribute to app configuration #27892

sonwan2020 · 2024-02-23T08:13:10Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.

Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

For help with Step 2 / "ARM review", see https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-02-23T08:13:14Z

Next Steps to Merge

✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2024-02-23T08:13:15Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

compared swaggers (via Oad v0.10.5)]	new version	base version
ContainerApps.json	2024-02-02-preview(02c7595)	2023-05-01(main)
ContainerApps.json	2024-02-02-preview(02c7595)	2023-11-02-preview(main)

️⚠️LintDiff: 2 Warnings warning [Detail]

compared tags (via openapi-validator v2.2.0)	new version	base version
package-preview-2024-02	package-preview-2024-02(02c7595)	package-preview-2024-02(release-app-Microsoft.App-2024-02-02-preview)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L867
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L871

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L99
`❌` GetResponseCodes	GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L100
`❌` NoErrorCodeResponses	Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L131
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L198
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L221
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L264
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:location. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L304
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:type. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L304
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not have default value, property:activeRevisionsMode. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L304
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not have default value, property:transport. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L304
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:allowedOrigins. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L304
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not have default value, property:appProtocol. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L304
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:type. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L304
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not have default value, property:maxReplicas. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L304
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L330
`❌` ResourceNameRestriction	The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L342
`❌` ParametersInPost	customHostname is a query parameter. Post operation must not contain any query parameter other than api-version. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L349
`❌` ResourceNameRestriction	The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L394
`❌` ResourceNameRestriction	The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L440
`❌` PostResponseCodes	Synchronous POST operations must have one of the following combinations of responses - 200 and default ; 204 and default. They also must not have other response codes. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L441
`❌` NoErrorCodeResponses	Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L472
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L534
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L593
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L759
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L759
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L759
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L759
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L791
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L791
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/preview/2024-02-02-preview/ContainerApps.json#L791

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-02-23T08:13:15Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 0ede3b4ff3b4d4e3a3bdfadf93ef240cc8e10d9e. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-appcontainers [View full logs] [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation ContainerAppsAPIClientOperationsMixin.get_custom_domain_verification_id
info	[Changelog]   - Added operation JobsOperations.get_detector
info	[Changelog]   - Added operation JobsOperations.list_detectors
info	[Changelog]   - Added operation JobsOperations.proxy_get
info	[Changelog]   - Added operation group AppResiliencyOperations
info	[Changelog]   - Added operation group BuildAuthTokenOperations
info	[Changelog]   - Added operation group BuildersOperations
info	[Changelog]   - Added operation group BuildsByBuilderResourceOperations
info	[Changelog]   - Added operation group BuildsOperations
info	[Changelog]   - Added operation group DaprComponentResiliencyPoliciesOperations
info	[Changelog]   - Added operation group DaprSubscriptionsOperations
info	[Changelog]   - Added operation group DotNetComponentsOperations
info	[Changelog]   - Added operation group FunctionsExtensionOperations
info	[Changelog]   - Added operation group JavaComponentsOperations
info	[Changelog]   - Added operation group ManagedEnvironmentUsagesOperations
info	[Changelog]   - Added operation group UsagesOperations
info	[Changelog]   - Model AuthConfig has a new parameter encryption_settings
info	[Changelog]   - Model AvailableWorkloadProfileProperties has a new parameter gpus
info	[Changelog]   - Model CertificateProperties has a new parameter certificate_key_vault_properties
info	[Changelog]   - Model CertificateProperties has a new parameter certificate_type
info	[Changelog]   - Model Configuration has a new parameter runtime
info	[Changelog]   - Model CustomDomainConfiguration has a new parameter certificate_key_vault_properties
info	[Changelog]   - Model DaprComponent has a new parameter service_component_bind
info	[Changelog]   - Model GithubActionConfiguration has a new parameter build_environment_variables
info	[Changelog]   - Model Ingress has a new parameter additional_port_mappings
info	[Changelog]   - Model Ingress has a new parameter target_port_http_scheme
info	[Changelog]   - Model Job has a new parameter extended_location
info	[Changelog]   - Model JobPatchProperties has a new parameter extended_location
info	[Changelog]   - Model LogAnalyticsConfiguration has a new parameter dynamic_json_columns
info	[Changelog]   - Model Login has a new parameter token_store
info	[Changelog]   - Model ManagedEnvironment has a new parameter app_insights_configuration
info	[Changelog]   - Model ManagedEnvironment has a new parameter identity
info	[Changelog]   - Model ManagedEnvironment has a new parameter open_telemetry_configuration
info	[Changelog]   - Model ManagedEnvironmentStorageProperties has a new parameter nfs_azure_file
info	[Changelog]   - Model ServiceBind has a new parameter client_type
info	[Changelog]   - Model ServiceBind has a new parameter customized_keys

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 0ede3b4ff3b4d4e3a3bdfadf93ef240cc8e10d9e. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh]  Time     Time  Current
cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
cmderr	[init.sh] 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     063k      0 --:--:-- --:--:-- --:--:--  163k
cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
cmderr	[init.sh] Computing checksum with sha256sum
cmderr	[init.sh] Checksums matched!
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-appcontainers [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 0ede3b4ff3b4d4e3a3bdfadf93ef240cc8e10d9e. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/appcontainers/armappcontainers [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 0ede3b4ff3b4d4e3a3bdfadf93ef240cc8e10d9e. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-appcontainers [View full logs] [Preview SDK Changes]
- azure-arm-appcontainers-2.1.0-beta.1.tgz

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from 0ede3b4ff3b4d4e3a3bdfadf93ef240cc8e10d9e. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️app [View full logs] [Preview Schema Changes]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 0ede3b4ff3b4d4e3a3bdfadf93ef240cc8e10d9e. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.app.DefaultTag [View full logs] [Preview SDK Changes]
- Az.ContainerAppsApi.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-02-23T08:13:16Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/appcontainers/armappcontainers	https://apiview.dev/Assemblies/Review/c5375c6f5a4443168e64c981277b8377?revisionId=a0bb9daebe8e44849e17468e232ef0a4
Java	azure-resourcemanager-appcontainers	https://apiview.dev/Assemblies/Review/7da9ac1e2db64477ada2ba8bbb71169b?revisionId=a8b0da4522474582910c195cfa16ec64
JavaScript	@azure/arm-appcontainers	https://apiview.dev/Assemblies/Review/ba41cd9978b542efb0688a072b2319a1?revisionId=b9268ab639a744dcb38050b3605fd3ce
Swagger	Microsoft.App	https://apiview.dev/Assemblies/Review/53999dbad23b45cba7812a00a713cab8?revisionId=9bf0b844c9244d85bbf1e48d42472926

…-app-runtime' of https://github.com/sonwan2020/azure-rest-api-specs into sonwan/app-runtime

ms-zhenhua · 2024-02-27T08:38:52Z

specification/app/resource-manager/Microsoft.App/preview/2024-02-02-preview/ContainerApps.json

+    "Runtime": {
+      "description": "Container App Runtime configuration.",
+      "type": "object",
+      "properties": {


kind and java should not have default values, because the user may want to update only one of them.
https://github.com/Azure/azure-rest-api-specs/pull/27892/checks?check_run_id=22018340669

thanks, default value removed

openapi-workflow-bot · 2024-02-27T08:39:38Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

openapi-pipeline-app · 2024-02-27T14:38:05Z

Swagger Validation Report

️🔄BreakingChange inProgress [Detail]

️⌛Breaking Change(Cross-Version) pending [Detail]

️🔄LintDiff inProgress [Detail]

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️🔄SwaggerAPIView inProgress [Detail]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️🔄SemanticValidation inProgress [Detail]

️⌛SpellCheck pending [Detail]

️⌛PR Summary pending [Detail]

️⌛Automated merging requirements met pending [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

daniv-msft · 2024-02-29T20:32:35Z

specification/app/resource-manager/Microsoft.App/preview/2024-02-02-preview/ContainerApps.json

+            "modelAsString": true
+          }
+        },
+        "java": {


Could you please confirm that ARM will treat this object as optional, and that we won't have to declare it if the customer didn't define it?

sure, no "required" restriction on runtime variables

sonwan2020 · 2024-03-01T05:13:24Z

20240301 we decide to remove the kind variable in the runtime object

sonwan2020 · 2024-03-04T01:02:13Z

/pr RequestMerge

* add configuration.runtime for apps

* Adds base for updating Microsoft.App from version preview/2023-11-02-preview to version 2024-02-02-preview * Updates readme * Updates API version in new specs and examples * Functions Extension endpoint for Web RP (#27873) * Functions extension api-spec commit * merge with latest * Functions Extension in 2024-02-02-preview * correcetd version in readme * avacado fail fix - version * pattern addition * fix for PathForResourceAction * lint diff and model validation checks * AutoRest exception fix * endpoint response as string and not schema * response schema with string * example schema * example within spec * extension example with data * extensions example with body * body as string * [Microsoft.App] add runtime attribute to app configuration (#27892) * add configuration.runtime for apps * Add Nacos For Java Component. (#28045) * Add Nacos For Java Component. * fix spell check. * [Container Apps] Update Runtime to add DotNet support (#28001) * [Container Apps] Update Runtime to add DotNet support * Remove default value * Rename dotNet to dotnet * [Container Apps] Remove AspireResourceServerApi type for DotNetComponent (#28005) * [Container Apps] Remove AspireResourceServerApi type for DotNetComponent * Only keep changes to 2024-02-02-preview * [ContainerApp] Support peer traffic encryption. (#28129) * Make the JavaComponent definitions polymorphism and expose fqdn for sba and eureka (#28102) * Make the JavaComponent definitions polymorphism * fix api version * revert error response change * refine examples * fix default value * fix * fix * try to remove required * try remove require in patch body * fix * try fix lint * fix * add suppression for discriminator * fix --------- Co-authored-by: Xuyang Cao <[email protected]> * ContainerAppsBuild and ContainerAppsPatch API (#27982) * Added CloudBuild and CloudPatch * Fixed pipeline errors * Added ContainerApp example * Fixed typo in example * Fixed linting error * Fixed spacing * Addressed comments * Addressed comments and modified sample * Fixed linting error * Addressed comments * Linting * Fixed typo * Fixed Typo * Resolving model validation error * [Microsoft.App] add java agent related properties (#28192) * add java agent related properties * fix build error * fix format * re-run pipeline * update enum list and fix typo * revert cspell config * update level field type from enum to string * add identifiers for array prop * Fix error response for aca (#28425) * fix * fix * Adding identity for scale rules (#28283) * Adding identity for scale rules * fix scale example * Fix schema issue for Microsoft.App in 2024-02-02-preview (#28454) * fix * fix * fix * fix * fix * fix * Update Container Apps Swagger Schema to include kind property (#28405) * Added support for KIND property to container apps schema * added reference to example request schema * prettier check * changes to example conforming to swagger * used enum for app kind * minor fixes * merged main * Revert "merged main" This reverts commit 2437d60. * fixed checks * Add detailed job execution to api (#27977) * Add detailed job execution to api * Add fields * address comment * add x-ms-identifiers * prettier * address comments * Address comments * Address comments * update example * Fix property name * Fix example * [Microsoft.App] optimize java agent related properties (#28573) * optimize java agent related props * fix * adding logging property to include logger settings --------- Co-authored-by: Bowen Wan <[email protected]> * Add accountName for queueScaler (#28672) * add accountName for queueScaler * updated example * updated * updated * updated * Adding identity settings (#28117) * Adding identity settings * fix casing in examples * Switch to array since ARM doesn't allow dictionaries. * identity property should be required. * prettier * Updating description * Adding Jobs spec * Update specification/app/resource-manager/Microsoft.App/preview/2024-02-02-preview/Jobs.json Co-authored-by: Jitin John <[email protected]> * Move IdentitySettings to CommonDefinitions --------- Co-authored-by: Jitin John <[email protected]> * Add SessionPools and Sessions (#28047) * Add SessionPools.json and Sessions.json * Add private endpoint connections for managed environment (#28775) * add pe * fix * fix * fix * fix * fix * fix * use v5 * fix * fix * Add support for SMB storage in connectedEnvironment (#29158) * Add support for SMB storage in connectedEnvironment * move smb properties to common * fix reference --------- Co-authored-by: [email protected] <[email protected]> * API spec for LogicApps extension on Microsoft.App (#29083) * API spec for LogicApps extension on Microsoft.App * format * fix typos * fix issues * fix example references * fix more issues * fix issues * fix more model validation * fix * fix model * fix format * fix lintdiff * fix example * fix headers * add delete * add missing file --------- Co-authored-by: Anand G Menon <[email protected]> * Add publicNetworkAccess in managed environment (#29092) * fix * fix * fix example * fix lint * revert previous change for patch * fix go sdk duplicate schema * fix go sdk duplicate schema * fix billing meter * fix billing meter --------- Co-authored-by: Jitin John <[email protected]> Co-authored-by: SushmithaVReddy <[email protected]> Co-authored-by: sonwan2020 <[email protected]> Co-authored-by: Xiangyang Yu <[email protected]> Co-authored-by: daniv-msft <[email protected]> Co-authored-by: Xuyang Cao <[email protected]> Co-authored-by: Xuyang Cao <[email protected]> Co-authored-by: Harry Li <[email protected]> Co-authored-by: Jimmy Fang <[email protected]> Co-authored-by: Vaclav Turecek <[email protected]> Co-authored-by: Shubham Sachdeva <[email protected]> Co-authored-by: lihaMSFT <[email protected]> Co-authored-by: Bowen Wan <[email protected]> Co-authored-by: njucz <[email protected]> Co-authored-by: yitaopan <[email protected]> Co-authored-by: anandgmenon <[email protected]> Co-authored-by: [email protected] <[email protected]>

sonwan2020 added 2 commits February 23, 2024 15:21

add configuration.runtime for apps

7efcf40

add runtime in app configuration

45571b6

sonwan2020 requested review from Juliehzl and jijohn14 as code owners February 23, 2024 08:13

fix format

deac963

azure-sdk mentioned this pull request Feb 23, 2024

[AutoPR sdk/resourcemanager/appcontainers/armappcontainers] [Microsoft.App] add runtime attribute to app configuration azure-sdk/azure-sdk-for-go#8919

Closed

AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 23, 2024

sonwan2020 changed the title ~~add runtime attribute to app configuration~~ [Microsoft.App] add runtime attribute to app configuration Feb 26, 2024

sonwan2020 closed this Feb 26, 2024

sonwan2020 added 2 commits February 27, 2024 15:04

add runtime.kind

d9807de

Merge branch 'sonwan2020/release-app-Microsoft.App-2024-02-02-preview…

77598f0

…-app-runtime' of https://github.com/sonwan2020/azure-rest-api-specs into sonwan/app-runtime

sonwan2020 reopened this Feb 27, 2024

sonwan2020 added 2 commits February 27, 2024 15:29

fix

0832d39

remove default

a793c6e

ms-zhenhua reviewed Feb 27, 2024

View reviewed changes

ms-zhenhua added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 27, 2024

remove default for enableMetrics

6d5f81b

daniv-msft reviewed Feb 29, 2024

View reviewed changes

daniv-msft mentioned this pull request Feb 29, 2024

[Container Apps] Update Runtime to add DotNet support #28001

Merged

7 tasks

remove kind property

02c7595

sonwan2020 removed the ARMChangesRequested label Mar 1, 2024

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 1, 2024

ms-zhenhua added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 1, 2024

microsoft-github-policy-service bot added the MergeRequested label Mar 4, 2024

TimLovellSmith enabled auto-merge (squash) March 4, 2024 17:51

ms-zhenhua approved these changes Mar 5, 2024

View reviewed changes

TimLovellSmith merged commit 5ad9810 into Azure:release-app-Microsoft.App-2024-02-02-preview Mar 5, 2024

Juliehzl pushed a commit to Juliehzl/azure-rest-api-specs that referenced this pull request Jun 4, 2024

[Microsoft.App] add runtime attribute to app configuration (Azure#27892)

9e305ac

* add configuration.runtime for apps

[Microsoft.App] add runtime attribute to app configuration #27892

[Microsoft.App] add runtime attribute to app configuration #27892

Uh oh!

Conversation

sonwan2020 commented Feb 23, 2024

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Breaking changes review (Diagram Step 1)

ARM API changes review (Diagram Step 2)

Diagram footnotes

Purpose of this PR

Due diligence checklist

Additional information

Getting help

Uh oh!

openapi-pipeline-app bot commented Feb 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app bot commented Feb 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Feb 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Feb 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

ms-zhenhua Feb 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonwan2020 Feb 27, 2024

Choose a reason for hiding this comment

Uh oh!

openapi-workflow-bot bot commented Feb 27, 2024

Uh oh!

openapi-pipeline-app bot commented Feb 27, 2024

Swagger Validation Report

Uh oh!

daniv-msft Feb 29, 2024

Choose a reason for hiding this comment

Uh oh!

sonwan2020 Mar 1, 2024

Choose a reason for hiding this comment

Uh oh!

daniv-msft Mar 1, 2024

Choose a reason for hiding this comment

Uh oh!

sonwan2020 commented Mar 1, 2024

Uh oh!

sonwan2020 commented Mar 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openapi-pipeline-app bot commented Feb 23, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 23, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 23, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 23, 2024 •

edited

Loading

ms-zhenhua Feb 27, 2024 •

edited

Loading