Express Route Cross Connection Swagger changes as per PM requirements#2644
Conversation
Automation for azure-libraries-for-javaA PR has been created for you: |
Automation for azure-sdk-for-goA PR has been created for you: |
Automation for azure-sdk-for-pythonA PR has been created for you: |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
…into crossConnectionChanges
…est-api-specs into crossConnectionChanges
…est-api-specs into crossConnectionChanges
There was a problem hiding this comment.
Please review and update attributes that are readOnly in this definition
There was a problem hiding this comment.
A better name would be ExpressRouteCrossConnectionPeeringProperties
| "description": "The peerings in an express route cross connection." | ||
| }, | ||
| "nextLink": { | ||
| "type": "string", |
There was a problem hiding this comment.
nextLink should be readOnly
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: 💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡 File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: 💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡 File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Apart from a few minor comments, looks okay. Need to check linter/model validator issues
There was a problem hiding this comment.
Please rename these as something generic like "connectionString", anything resembling actual keys should be avoided here
There was a problem hiding this comment.
Same comment as above for the subscriptionId here
There was a problem hiding this comment.
A better name would be ExpressRouteCrossConnectionPeeringProperties
There was a problem hiding this comment.
A better name would be ExpressRouteCrossConnectionPeeringList
|
As an FYI, existing and newer linter validations should be addressed for newer API versions per our offline conversations. |
… 2018 (#2642) * Add support for Express Route Circuit Connection resource as a child of Express Route Circuit Peering in 2018-02-01 API (#2358) * copy all files from 2018-01-01 to 2018-02-01 * update api version to 2018 in all files * add express route circuit connection as child of express route bgp peering * update readme.md * add examples * fix travis build error * fix travis build error * fix indentation errors * update reference to circuit connections in peering * fix indentation * Merge Express Route Circuit Connection to Networking2018-02-01 (#2370) * copy all files from 2018-01-01 to 2018-02-01 * update api version to 2018 in all files * add express route circuit connection as child of express route bgp peering * update readme.md * add examples * fix travis build error * fix travis build error * fix indentation errors * update reference to circuit connections in peering * fix indentation * fix indentation * fix indentation' * get latest file * Fix indentation * fix key * fix indentation and example * fix indentation * fix indentation * make circuit con singular * add fix as PR #2364 (#2376) * Network feature: Setting custom ipsec policy for Virtual Network Gateway P2S clients. (#2521) * 1443089: Network feature: Setting custom ipsec policy for Virtual Network Gateway P2S clients. * 1443089:Fix network ReadMe file. * 1443089:Fix network ReadMe file. * Temporary bug fix * Add support for Express Route Provider APIs (#2532) * Add support for Express Route Provider APIs A new top level NRP resource ExpressRouteCrossConnection is being introduced with this change. This resource shadows the customer ExpressRouteCircuit resouce in the customer subscription and enables the provider to perform CRUD operations on some of the sub-resources, such as peerings on the ExpressRoute Circuit * remove wrong enum values from circuit connection status and fix enum … (#2572) * remove wrong enum values from circuit connection status and fix enum name * Update ExpressRouteCrossConnection Route Table Summary Record (#2574) * Update CrossConnection Route Table Summary record * [Network-2018-02-01] DDoS Protection Plan resource (#2567) * Initial version * Add eol * Add extra property in example * Add default values for fields * Rename operation IDs * Make 'id' read-only for all network resources * Revert "Make 'id' read-only for all network resources" * Fix reference * making peer express route circuit peering and express route circuit peering as references (#2696) * Express Route Cross Connection Swagger changes as per PM requirements (#2644) * Fixed operationIds for non-CRUD operations in ExpressRouteCrossConnections (#2720) * Making travis run > 10 mins (#2739)
5 participants
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger