Fixes after breaking changes in Express Route Peerings swagger by MikhailTryakhov · Pull Request #6036 · Azure/azure-powershell

MikhailTryakhov · 2018-04-24T17:57:17Z

Description

Swagger PR Azure/azure-rest-api-specs#2644 contains option name changing. Need to be dixed in PowerShell. No breaking changes for PS, true story :)

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate change log has been updated
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- the changes have gone through a cmdlet design review
- the cmdlet markdown files were generated using the platyPS module

markcowl · 2018-05-01T23:11:34Z

src/ResourceManager/Network/Commands.Network.Test/Commands.Network.Test.csproj

    </Reference>
-    <Reference Include="Microsoft.Azure.Management.Network, Version=17.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
-      <HintPath>..\..\..\packages\Microsoft.Azure.Management.Network.17.0.0-preview\lib\net452\Microsoft.Azure.Management.Network.dll</HintPath>
+    <Reference Include="Microsoft.Azure.Management.Network, Version=19.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">


I think these should all be the same version

markcowl · 2018-05-01T23:11:46Z

src/ResourceManager/Network/Commands.Network.Test/packages.config

  <package id="Microsoft.Azure.Management.Authorization" version="2.0.0" targetFramework="net452" />
  <package id="Microsoft.Azure.Management.Compute" version="18.0.0" targetFramework="net452" />
-  <package id="Microsoft.Azure.Management.Network" version="17.0.0-preview" targetFramework="net452" />
+  <package id="Microsoft.Azure.Management.Network" version="19.0.0-preview" targetFramework="net452" />


cannot be different

markcowl · 2018-05-01T23:11:58Z

src/ResourceManager/Network/Commands.Network/Commands.Network.Netcore.csproj

  <ItemGroup >
    <PackageReference Include="AutoMapper" Version="6.2.2" />
-    <PackageReference Include="Microsoft.Azure.Management.Network" Version="17.0.0-preview" />
+    <PackageReference Include="Microsoft.Azure.Management.Network" Version="19.0.0-preview" />


same comment

markcowl · 2018-05-01T23:12:05Z

src/ResourceManager/Network/Commands.Network/Commands.Network.csproj

    </Reference>
-    <Reference Include="Microsoft.Azure.Management.Network, Version=17.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
-      <HintPath>..\..\..\packages\Microsoft.Azure.Management.Network.17.0.0-preview\lib\net452\Microsoft.Azure.Management.Network.dll</HintPath>
+    <Reference Include="Microsoft.Azure.Management.Network, Version=19.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">


same comment

markcowl · 2018-05-01T23:12:22Z

src/ResourceManager/Network/Commands.Network/packages.config

  <package id="AutoMapper" version="6.0.2" targetFramework="net452" />
  <package id="Microsoft.Azure.KeyVault.Core" version="1.0.0" targetFramework="net45" />
-  <package id="Microsoft.Azure.Management.Network" version="17.0.0-preview" targetFramework="net452" />
+  <package id="Microsoft.Azure.Management.Network" version="19.0.0-preview" targetFramework="net452" />


same comment

markcowl · 2018-05-01T23:13:05Z

src/ResourceManager/Sql/Commands.Sql.Test/Commands.Sql.Test.csproj

-    <Reference Include="Microsoft.Azure.Management.Network, Version=17.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
-      <HintPath>..\..\..\packages\Microsoft.Azure.Management.Network.17.0.0-preview\lib\net452\Microsoft.Azure.Management.Network.dll</HintPath>
+    <Reference Include="Microsoft.Azure.Management.Network, Version=18.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
+      <HintPath>..\..\..\packages\Microsoft.Azure.Management.Network.18.0.0-preview\lib\net452\Microsoft.Azure.Management.Network.dll</HintPath>


note: the network version needs to be published before we can accept it in preview

markcowl · 2018-05-01T23:13:32Z

src/ResourceManager/Common/Commands.Common.Strategies/Common.Strategies.Netcore.csproj

  <ItemGroup>
    <PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="1.6.0-preview" />
    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="17.5.0" />
-    <PackageReference Include="Microsoft.Azure.Management.Network" Version="17.0.0-preview" />


what are the functional changes that go with these assembly changes?

Fixes after breaking changes in Express Route Peerings

8e62af5

azuresdkci added the needs-review label Apr 24, 2018

vinayada1 previously approved these changes Apr 24, 2018

View reviewed changes

Fixed packages version

84eafbd

MikhailTryakhov dismissed vinayada1’s stale review via 84eafbd April 24, 2018 18:29

MikhailTryakhov added 4 commits April 24, 2018 12:11

fixed wrong model usage

f157e4d

fixed package version in netcore

7f1d43c

updated package versions

a255edc

Fixed mistyping in config file

4a81853

markcowl added the Post Build label Apr 25, 2018

Added new SDK version locally to test

3c2b575

markcowl removed the Post Build label May 1, 2018

markcowl requested changes May 1, 2018

View reviewed changes

markcowl added needs-revision and removed needs-review labels May 1, 2018

markcowl assigned MikhailTryakhov May 1, 2018

maddieclayton added the Merge Conflicts label May 2, 2018

MikhailTryakhov closed this May 7, 2018

praries880 deleted the remote/preview-fix branch June 1, 2018 17:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes after breaking changes in Express Route Peerings swagger#6036

Fixes after breaking changes in Express Route Peerings swagger#6036
MikhailTryakhov wants to merge 7 commits intopreviewfrom
remote/preview-fix

MikhailTryakhov commented Apr 24, 2018

Uh oh!

markcowl May 1, 2018

Uh oh!

markcowl May 1, 2018

Uh oh!

markcowl May 1, 2018

Uh oh!

markcowl May 1, 2018

Uh oh!

markcowl May 1, 2018

Uh oh!

markcowl May 1, 2018

Uh oh!

markcowl May 1, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Conversation

MikhailTryakhov commented Apr 24, 2018

Description

Checklist

Uh oh!

markcowl May 1, 2018

Choose a reason for hiding this comment

Uh oh!

markcowl May 1, 2018

Choose a reason for hiding this comment

Uh oh!

markcowl May 1, 2018

Choose a reason for hiding this comment

Uh oh!

markcowl May 1, 2018

Choose a reason for hiding this comment

Uh oh!

markcowl May 1, 2018

Choose a reason for hiding this comment

Uh oh!

markcowl May 1, 2018

Choose a reason for hiding this comment

Uh oh!

markcowl May 1, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments