fixing overwritting issue

[azhao155]

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[azhao155]

1497fea
have overwritten some changes in Oct and Nov version, this is the fix.

[azuresdkciprbot]

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 85
After the PR: Warning(s): 0 Error(s): 85

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[AutorestCI]

Did a commit to Azure/azure-sdk-for-go:
Azure/azure-sdk-for-go@0719658

[AutorestCI]

Did a commit to Azure/azure-sdk-for-python:
Azure/azure-sdk-for-python@4e8cd54

[marstr]

Usurping this PR because I have some context. I hope you don't mind, @olydis!

[marstr]

@azhao155, I have some homework for you. Could you please find me the most recent API Version/commit with these changes that you are looking to replicate into this API Version? Bonus points if you can find me the PRs which introduced the changes that you're re-applying here. It'll help me speed up the process of reviewing, and maybe help us skip some of the process to get these in ASAP.

[azhao155]

@marstr
the 1101 under stable folder should contain all the changes, and the following are the changes i made and corresponding PR:

#2203
LoadBalancerCreateWithInboundNatPool.json
PublicIpAddressGet.json
PublicIpAddressList.json
loadBalancer.json
publicIpAddress.json

#2223
NetworkWatcherConnectionMonitorCreate.json
NetworkWatcherConnectionMonitorGet.json
NetworkWatcherConnectionMonitorList.json
NetworkWatcherConnectionMonitorQuery.json
NetworkWatcherConnectionMonitorStart.json
NetworkWatcherConnectionMonitorStop.json
networkWatcher.json

#2276
RouteFilterRuleCreate.json
RouteFilterRuleGet.json
RouteFilterRuleListByRouteFilter.json
RouteFilterRuleUpdate.json
routeFilter.json

[marstr]

Thanks @azhao155, I'll start taking a look at that now.

[marstr]

I've confirmed that, other than version number strings, the following addition is the only difference between master's 2017-11-01 API Version and @azhao155's 2018-01-1 API Version.

"requestBodyCheck": { 
          "type": "boolean", 
           "description": "Whether allow WAF to check request Body." 
}, 
"maxRequestBodySize": { 
           "type": "integer", 
           "format": "int32", 
           "maximum": 128, 
           "exclusiveMaximum": false, 
           "minimum": 8, 
           "exclusiveMinimum": false, 
           "description": "Maxium request body size for WAF."