Merge Network-2018-02-01 to Master Networking Swagger Changes for Feb 2018 by dedhar · Pull Request #2642 · Azure/azure-rest-api-specs

dedhar · 2018-03-13T18:41:27Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…of Express Route Circuit Peering in 2018-02-01 API (#2358) * copy all files from 2018-01-01 to 2018-02-01 * update api version to 2018 in all files * add express route circuit connection as child of express route bgp peering * update readme.md * add examples * fix travis build error * fix travis build error * fix indentation errors * update reference to circuit connections in peering * fix indentation

* copy all files from 2018-01-01 to 2018-02-01 * update api version to 2018 in all files * add express route circuit connection as child of express route bgp peering * update readme.md * add examples * fix travis build error * fix travis build error * fix indentation errors * update reference to circuit connections in peering * fix indentation * fix indentation * fix indentation' * get latest file * Fix indentation * fix key * fix indentation and example * fix indentation * fix indentation * make circuit con singular

…way P2S clients. (#2521) * 1443089: Network feature: Setting custom ipsec policy for Virtual Network Gateway P2S clients. * 1443089:Fix network ReadMe file. * 1443089:Fix network ReadMe file. * Temporary bug fix

* Add support for Express Route Provider APIs A new top level NRP resource ExpressRouteCrossConnection is being introduced with this change. This resource shadows the customer ExpressRouteCircuit resouce in the customer subscription and enables the provider to perform CRUD operations on some of the sub-resources, such as peerings on the ExpressRoute Circuit

#2572) * remove wrong enum values from circuit connection status and fix enum name

* Update CrossConnection Route Table Summary record

AutorestCI · 2018-03-13T18:54:14Z

Automation for azure-libraries-for-java

A PR has been created for you:
Azure/azure-libraries-for-java#372

AutorestCI · 2018-03-13T19:15:56Z

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

AutorestCI · 2018-03-13T19:21:50Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#1402

murilogr

Do not merge until #2567 is merged into Network-2018-02-01

* Initial version * Add eol * Add extra property in example * Add default values for fields * Rename operation IDs * Make 'id' read-only for all network resources * Revert "Make 'id' read-only for all network resources" This reverts commit 9a32d84.

murilogr

#2567 was merged. It contains all my changes. Looks good for my changes.

murilogr · 2018-03-13T23:38:00Z

It depends on the fix #2646

dsgouda · 2018-03-15T17:33:06Z

@dedhar can you pull down the latest changes from master into Network-2018-02-01 and push the commit. That might probably be causing the build errors

dsgouda · 2018-03-15T17:40:38Z

specification/network/resource-manager/Microsoft.Network/stable/2018-02-01/virtualNetwork.json

+          "description": "Indicates if VM protection is enabled for all the subnets in the virtual network."
+        },
+        "ddosProtectionPlan": {
+          "$ref": "#/definitions/SubResource",


Please fix this reference to ./network.json#/definitions/SubResource

@murilogr : Can you take a look and fix this in your original PR?

* Initial version * Add eol * Add extra property in example * Add default values for fields * Rename operation IDs * Make 'id' read-only for all network resources * Revert "Make 'id' read-only for all network resources" This reverts commit 9a32d84. * Fix reference

…est-api-specs into Network-2018-02-01

…into Network-2018-02-01

dsgouda · 2018-03-16T15:55:54Z

@lmazuel Is the python failure due to XmsParameterLocation errors reported?

dsgouda · 2018-03-16T17:39:32Z

Do not merge before #2644

…into Network-2018-02-01

dsgouda · 2018-03-16T18:41:59Z

@vinayada1 Please pull the latest changes from this branch and work on your changes

…eering as references (#2696)

…#2644)

…tions (#2720)

AutorestCI · 2018-03-22T22:36:01Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#2534

dsgouda · 2018-03-22T23:26:28Z

@lmazuel Can you take a look at the CI failures here

dsgouda · 2018-03-23T16:52:29Z

All builds are a go!

dsgouda

LGTM

lmazuel · 2018-03-23T20:07:13Z

@AutorestCI rebuild azure-sdk-for-python

* Remove async responses from Swagger * Update openapi-subtype * Remove x-ms-long-running-operation * Fix spelling * Prettier * Spelling * More spelling fixes Co-authored-by: Ben Viglietta <benvi@ntdev.microsoft.com>

dedhar and others added 7 commits January 29, 2018 17:35

add fix as PR #2364 (#2376)

d966adb

remove wrong enum values from circuit connection status and fix enum … (

fb621de

#2572) * remove wrong enum values from circuit connection status and fix enum name

Update ExpressRouteCrossConnection Route Table Summary Record (#2574)

b91f5af

* Update CrossConnection Route Table Summary record

azuresdkci assigned fearthecowboy Mar 13, 2018

AutorestCI mentioned this pull request Mar 13, 2018

[AutoPR network/resource-manager] Merge Network-2018-02-01 to Master Networking Swagger Changes for Feb 2018 Azure/azure-libraries-for-java#266

Closed

AutorestCI mentioned this pull request Mar 13, 2018

[AutoPR network/resource-manager] Merge Network-2018-02-01 to Master Networking Swagger Changes for Feb 2018 Azure/azure-sdk-for-python#2156

Closed

AutorestCI mentioned this pull request Mar 13, 2018

[AutoPR network/resource-manager] Merge Network-2018-02-01 to Master Networking Swagger Changes for Feb 2018 Azure/azure-sdk-for-go#1247

Closed

murilogr suggested changes Mar 13, 2018

View reviewed changes

murilogr reviewed Mar 13, 2018

View reviewed changes

salameer assigned dsgouda and unassigned fearthecowboy Mar 15, 2018

dsgouda suggested changes Mar 15, 2018

View reviewed changes

murilogr approved these changes Mar 15, 2018

View reviewed changes

dsgouda added 2 commits March 15, 2018 16:34

Merge branch 'Network-2018-02-01' of https://github.com/Azure/azure-r…

9cb0591

…est-api-specs into Network-2018-02-01

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

9b99506

…into Network-2018-02-01

dsgouda added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Mar 16, 2018

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

633ff69

…into Network-2018-02-01

making peer express route circuit peering and express route circuit p…

bef8ab1

…eering as references (#2696)

dsgouda requested a review from a user March 19, 2018 22:37

dsgouda requested review from DeepakRajendranMsft and vladbarosan as code owners March 19, 2018 22:37

vinayada1 and others added 2 commits March 19, 2018 15:50

Express Route Cross Connection Swagger changes as per PM requirements (…

c9ee826

…#2644)

Fixed operationIds for non-CRUD operations in ExpressRouteCrossConnec…

0f1c1a7

…tions (#2720)

dsgouda closed this Mar 22, 2018

dsgouda reopened this Mar 22, 2018

AutorestCI mentioned this pull request Mar 22, 2018

[AutoPR network/resource-manager] Merge Network-2018-02-01 to Master Networking Swagger Changes for Feb 2018 Azure/azure-sdk-for-node#2533

Closed

AutorestCI mentioned this pull request Mar 22, 2018

[AutoPR network/resource-manager] Merge Network-2018-02-01 to Master Networking Swagger Changes for Feb 2018 Azure/azure-sdk-for-go#1402

Merged

Making travis run > 10 mins (#2739)

dbde6f2

dsgouda approved these changes Mar 23, 2018

View reviewed changes

dsgouda merged commit 682e15a into master Mar 23, 2018

murilogr mentioned this pull request Mar 29, 2018

Network 2018-02-01 Azure/azure-sdk-for-net#4178

Merged

8 tasks

Nilambari mentioned this pull request Mar 30, 2018

Generate sdk-for-net artifacts from Networking Swagger Network-2018-02-01 branch Azure/azure-sdk-for-net#4181

Closed

9 tasks

lmazuel deleted the Network-2018-02-01 branch July 25, 2018 23:03

Conversation

dedhar commented Mar 13, 2018 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Mar 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-libraries-for-java

Uh oh!

AutorestCI commented Mar 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Mar 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

murilogr left a comment

Choose a reason for hiding this comment

Uh oh!

murilogr left a comment

Choose a reason for hiding this comment

Uh oh!

murilogr commented Mar 13, 2018

Uh oh!

dsgouda commented Mar 15, 2018

Uh oh!

dsgouda Mar 15, 2018

Choose a reason for hiding this comment

Uh oh!

dedhar Mar 15, 2018

Choose a reason for hiding this comment

Uh oh!

dsgouda commented Mar 16, 2018

Uh oh!

dsgouda commented Mar 16, 2018

Uh oh!

dsgouda commented Mar 16, 2018

Uh oh!

AutorestCI commented Mar 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

dsgouda commented Mar 22, 2018

Uh oh!

dsgouda commented Mar 23, 2018

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

lmazuel commented Mar 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Comments

dedhar commented Mar 13, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Mar 13, 2018 •

edited

Loading

AutorestCI commented Mar 13, 2018 •

edited

Loading

AutorestCI commented Mar 13, 2018 •

edited

Loading

AutorestCI commented Mar 22, 2018 •

edited

Loading