Conversation
|
@murilogr Please link the related rest spec PR |
| <Version>18.0.0-preview</Version> | ||
| <PackageTags>Microsoft Azure Network management;Network;Network management;</PackageTags> | ||
| <PackageReleaseNotes> | ||
| <![CDATA[ |
There was a problem hiding this comment.
Please update the package release notes for this version
|
Link for the REST API merge: REST API |
dsgouda
left a comment
There was a problem hiding this comment.
Please run msbuild build.proj /t:build /p:Scope=SDKs\Network
This should modify the .props file, please commit these changes
Looks good other than that
| throw new ValidationException(ValidationRules.CannotBeNull, "this.Client.SubscriptionId"); | ||
| } | ||
| string apiVersion = "2018-01-01"; | ||
| string apiVersion = "2018-02-01"; |
There was a problem hiding this comment.
@murilogr can you confirm if this change was expected.
There was a problem hiding this comment.
It's expected. If you look at the diff from psSdkJson6 to this branch, we're just changing the version.
For some reason, in the first time, autorest generated Client.ApiVersion, but, in the second time, it reverted to "apiVersion".
|
@dsgouda I updated props file generated by the build |
Description
Automatically generated based on latest REST API specs.
REST API
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.