Skip to content

Network 2018-02-01#4178

Merged
dsgouda merged 8 commits intoAzure:psSdkJson6from
murilogr:network2018_02_02
Apr 3, 2018
Merged

Network 2018-02-01#4178
dsgouda merged 8 commits intoAzure:psSdkJson6from
murilogr:network2018_02_02

Conversation

@murilogr
Copy link
Contributor

Description

Automatically generated based on latest REST API specs.

REST API


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@murilogr murilogr changed the title Network 2018-02-01 - Automated generation Network 2018-02-01 Mar 30, 2018
@dsgouda
Copy link
Contributor

dsgouda commented Mar 30, 2018

@murilogr Please link the related rest spec PR

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run
msbuild build.proj /t:build /p:Scope=SDKs\Network and commit any artifacts
Please create a generate.ps1 file similar to this and regenerate the code

<Version>18.0.0-preview</Version>
<PackageTags>Microsoft Azure Network management;Network;Network management;</PackageTags>
<PackageReleaseNotes>
<![CDATA[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the package release notes for this version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@murilogr
Copy link
Contributor Author

murilogr commented Apr 2, 2018

Link for the REST API merge: REST API

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run msbuild build.proj /t:build /p:Scope=SDKs\Network
This should modify the .props file, please commit these changes
Looks good other than that

throw new ValidationException(ValidationRules.CannotBeNull, "this.Client.SubscriptionId");
}
string apiVersion = "2018-01-01";
string apiVersion = "2018-02-01";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@murilogr can you confirm if this change was expected.

Copy link
Contributor Author

@murilogr murilogr Apr 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's expected. If you look at the diff from psSdkJson6 to this branch, we're just changing the version.

For some reason, in the first time, autorest generated Client.ApiVersion, but, in the second time, it reverted to "apiVersion".

@murilogr
Copy link
Contributor Author

murilogr commented Apr 3, 2018

@dsgouda I updated props file generated by the build

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit ffa7cda into Azure:psSdkJson6 Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments