Skip to content

Azfw ipgroups#10647

Closed
ssripadham wants to merge 70 commits intomasterfrom
azfw_ipgroups
Closed

Azfw ipgroups#10647
ssripadham wants to merge 70 commits intomasterfrom
azfw_ipgroups

Conversation

@ssripadham
Copy link
Contributor

@ssripadham ssripadham commented Dec 3, 2019

Description

- `Azure Firewall will support IpGroups can be used in the network/application/dnat rules as described below.
  • As a source or destination address in AZFW network rules
  • As a source address in AZFW application rules
  • As a source address in DNAT rules. `

1. Azure Firewall Application Rules

     "AzureFirewallApplicationRule": {
         "properties": {
           "name": {
             "type": "string",
             "description": "Name of the application rule."
           },
           "description": {
             "type": "string",
             "description": "Description of the rule."
           },
           ...
           "sourceIpGroups": {
             "type": "array",
             "description": "List of source IP Groups for this rule.",
             "items": {
               "type": "string"
             }
           },
       ...
     }
    }

2. Azure Firewall NAT Rules

   "AzureFirewallNatRule": {
         "properties": {
           "name": {
             "type": "string",
             "description": "Name of the NAT rule."
           },
           "description": {
             "type": "string",
             "description": "Description of the rule."
           },
          ...

    "sourceIpGroups": {
      "type": "array",
      "description": "List of source IP Groups for this rule.",
      "items": {
        "type": "string"
      }
    }
       …
   }
   }

3. Azure Firewall Network Rules

    "AzureFirewallNetworkRule": {
         "properties": {
           "name": {
             "type": "string",
             "description": "Name of the network rule."
           },
           "description": {
             "type": "string",
             "description": "Description of the rule."
           },
          ...
           "sourceIpGroups": {
             "type": "array",
             "description": "List of source IP Groups for this rule.",
             "items": {
               "type": "string"
             }
           },
           "destinationIpGroups": {
             "type": "array",
             "description": "List of destination IP Groups for this rule.",
             "items": {
               "type": "string"
             }
           },
       ...
    }
   }

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

VeryEarly and others added 30 commits October 5, 2019 11:13
Fix for #10613

1.Add DataBoxEdge to CreateMappings_rules.json.
2.Take the longest matched pattern when there are multiple ones.
Revert script change.
The term 'New-AzureStorageContainerSASToken' is not recognized as the name of a cmdlet.
need to use 'New-AzStorageContainerSASToken' instead
  - New-AzBatchPool was not correctly propagating some
    collections to the server.
anton-evseev
anton-evseev previously approved these changes Dec 4, 2019
New-AzFirewallNetworkRule -Name <String> [-Description <String>] [-SourceAddress <String[]>]
[-SourceIpGroup <String[]>] [-DestinationAddress <String[]>] [-DestinationIpGroup <String[]>]
[-DestinationFqdn <String[]>] -DestinationPort <String[]> -Protocol <String[]>
[-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like your targetFqdn parameter is still in the code but was removed from here, please confirm if it was still valid parameter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have fixed this.

VeryEarly and others added 4 commits December 5, 2019 16:15
Fix null ref in generated cmdlets when context is not set
[Storage] Update to SRP SDK 14.2.0, and add Quota parameter alias
@VeryEarly
Copy link
Collaborator

VeryEarly commented Dec 5, 2019

Hi @ssripadham ,

Some test cases need to be updated after your changes. And "ChangeLog.md" as well.

Fixed Parameterset

Fixed Parametersets and help md

Powershell changes for IpGroup support

Update md files

Add scenario tests

Fixed NatRuleCollection md

Resolve conflict

Fixed test

Fix Static Analysis
@ssripadham ssripadham mentioned this pull request Dec 6, 2019
8 tasks
@wyunchi-ms
Copy link
Contributor

Closing this since there is a new pr #10668.

@wyunchi-ms wyunchi-ms closed this Dec 6, 2019
@dingmeng-xue dingmeng-xue deleted the azfw_ipgroups branch May 13, 2022 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.