Closed
Conversation
…kAssemblies.ps1 to use the new paths
…kAssemblies.ps1 to use the new paths
…rly/azure-powershell into relative-paths-test#10072
…to relative-paths-test#10072
Fix for #10613 1.Add DataBoxEdge to CreateMappings_rules.json. 2.Take the longest matched pattern when there are multiple ones.
The term 'New-AzureStorageContainerSASToken' is not recognized as the name of a cmdlet. need to use 'New-AzStorageContainerSASToken' instead
- New-AzBatchPool was not correctly propagating some
collections to the server.
Update *psd1 for every module to use relative path, fix tooling issue in tools/CheckAssemblies.ps1
Fix mismatch between cmdlets and service in index.json
anton-evseev
previously approved these changes
Dec 4, 2019
VeryEarly
reviewed
Dec 5, 2019
| New-AzFirewallNetworkRule -Name <String> [-Description <String>] [-SourceAddress <String[]>] | ||
| [-SourceIpGroup <String[]>] [-DestinationAddress <String[]>] [-DestinationIpGroup <String[]>] | ||
| [-DestinationFqdn <String[]>] -DestinationPort <String[]> -Protocol <String[]> | ||
| [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>] |
Collaborator
There was a problem hiding this comment.
looks like your targetFqdn parameter is still in the code but was removed from here, please confirm if it was still valid parameter
Contributor
Author
There was a problem hiding this comment.
Thanks. I have fixed this.
Microsoft.Authorization/Policy* api version 2019-09-01
Adding PrivateRange to AzFirewall
Fix null ref in generated cmdlets when context is not set
[Storage] Update to SRP SDK 14.2.0, and add Quota parameter alias
Collaborator
|
Hi @ssripadham , Some test cases need to be updated after your changes. And "ChangeLog.md" as well. |
Fixed Parameterset Fixed Parametersets and help md Powershell changes for IpGroup support Update md files Add scenario tests Fixed NatRuleCollection md Resolve conflict Fixed test Fix Static Analysis
8 tasks
Contributor
|
Closing this since there is a new pr #10668. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1. Azure Firewall Application Rules
2. Azure Firewall NAT Rules
3. Azure Firewall Network Rules
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added