Skip to content

Update *psd1 for every module to use relative path, fix tooling issue in tools/CheckAssemblies.ps1#10228

Merged
VeryEarly merged 22 commits intoAzure:masterfrom
VeryEarly:relative-paths-test#10072
Dec 4, 2019
Merged

Update *psd1 for every module to use relative path, fix tooling issue in tools/CheckAssemblies.ps1#10228
VeryEarly merged 22 commits intoAzure:masterfrom
VeryEarly:relative-paths-test#10072

Conversation

@VeryEarly
Copy link
Collaborator

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@VeryEarly VeryEarly requested a review from markcowl October 9, 2019 15:28
@VeryEarly VeryEarly changed the title Relative paths test#10072 Update *psd1 for every module to use relative path, fix tooling issue in tools/CheckAssemblies.ps1 Oct 10, 2019
@VeryEarly VeryEarly requested a review from erich-wang October 10, 2019 02:29
@markcowl markcowl self-assigned this Oct 14, 2019
@markcowl
Copy link
Member

@VeryEarly, let's create a signed build based on your branch to test with for this.

@markcowl markcowl assigned VeryEarly and unassigned markcowl Oct 14, 2019
@wyunchi-ms wyunchi-ms assigned markcowl and unassigned VeryEarly Oct 23, 2019
@VeryEarly
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link
Contributor

Pull request contains merge conflicts.

}

$LoadedAssemblies = $LoadedAssemblies | ForEach-Object { $_.Substring(2).Replace(".dll", "") }
$LoadedAssemblies = $LoadedAssemblies | ForEach-Object { $_.Replace(".dll", "") }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really the only place we have this dependencyt, nice.

markcowl
markcowl previously approved these changes Oct 24, 2019
Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now let's come up with a plan with how we do validation, and we can target this PR for next release.

@markcowl markcowl assigned VeryEarly and unassigned markcowl Oct 24, 2019
@VeryEarly VeryEarly marked this pull request as ready for review October 24, 2019 09:04
@VeryEarly
Copy link
Collaborator Author

Now let's come up with a plan with how we do validation, and we can target this PR for next release.

I'll fix the CI and run smoke test against this build.

@VeryEarly
Copy link
Collaborator Author

smoke test passed (except machine learning compute which was deprecated)

@isra-fel
Copy link
Member

isra-fel commented Dec 3, 2019

why are there 77 psd1 changed but only 74 change log?

@VeryEarly
Copy link
Collaborator Author

why are there 77 psd1 changed but only 74 change log?

add changelog.md for datafactory and kusto, maintenance was not released yet so should not have change log

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@VeryEarly VeryEarly merged commit a2c7576 into Azure:master Dec 4, 2019
@VeryEarly VeryEarly deleted the relative-paths-test#10072 branch December 11, 2019 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants