Skip to content

Conversation

@b564518128
Copy link
Contributor

@b564518128 b564518128 commented Dec 3, 2019

Description

Add a new parameter "PrivateRange" to AzFirewall. It is a string array that specifies the ip addresses that should be treated as private so that the traffic to those addresses won't be snat'ed

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@VeryEarly
Copy link
Collaborator

Hi @b564518128 ,

Please fix the CI failures

@VeryEarly VeryEarly assigned VeryEarly and b564518128 and unassigned VeryEarly Dec 4, 2019
@b564518128
Copy link
Contributor Author

@VeryEarly Hi, I have fixed the CI. Please take a look and complete the PR

@VeryEarly VeryEarly merged commit 6c0a163 into Azure:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants