Skip to content

Conversation

@blueww
Copy link
Member

@blueww blueww commented Dec 4, 2019

Description

The PR currently use a private SRP SDK. Send it early for review first.
Will upgrade to released SRP SDK, when SDK PR is merged and SDK is released: Azure/azure-sdk-for-net#8977

Besides that, regenerate help file. Some code change not show in the help file also updated in help file. Anyway, this is expected to make the help file updated.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@VeryEarly
Copy link
Collaborator

Hi @blueww ,

test case also need to be re-record after SDK upgrade.

@blueww
Copy link
Member Author

blueww commented Dec 4, 2019

@VeryEarly
Test case only need to re-record when change API version (with upgrade SDK).
But for 14.1.0 to 14.2.0, the API version not change, so don't need to re-record the test case.

Anyway, don't merge this PR now as it use a private package. I will update to released SDK after the SDK pr merged and SDK released.
Please help to review if any comments for the code change.

@blueww
Copy link
Member Author

blueww commented Dec 5, 2019

@VeryEarly
I have removed the private SDK in this PR, as the SDK is already released.
So the "Do Not Merge" flag also removed.

Would you please help to review and merge the PR if no other issue?
Thanks!

@VeryEarly VeryEarly merged commit 1ec6244 into Azure:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants