Conversation
… them from requirements.txt
|
|
||
| pip3 install -r ${REPO_ROOT}/src/azure-cli/requirements.py3.linux.txt | ||
|
|
||
| pip3 check |
There was a problem hiding this comment.
What does a failure look like here? The old script did have a decent amount of amplifying information to make the necessary course of action obvious.
There was a problem hiding this comment.
Fair question! You can see an example of failure here:
https://travis-ci.org/Azure/azure-cli/jobs/549989807#L800-L803
| script: ./scripts/dependency/check.sh | ||
| script: ./scripts/ci/dependency_check.sh | ||
| python: 3.6 | ||
| # - stage: verify |
There was a problem hiding this comment.
Shouldn't there be more edits to the CI where we install the CLI from the requirements file, such as before running tests?
There was a problem hiding this comment.
Ah, there's a family of PRs coming as I update the tests and installers. This was just to get started before I unleash all of those, to make sure we are all on the same page in terms of general approach.
There was a problem hiding this comment.
So I think the existing script is more self-documenting in terms of what someone should do to fix the issue. I don't see where it calls out which requirements file is the offending one. Also, is this only being run for Python 3 Linux since that is what the CI runs? What about the other requirements files? How will we know they need to be updated?
There was a problem hiding this comment.
Mind if I address this in a follow-up? I think the points raised here are important, but I think it's more critical that I get started on overhauling the installers to use these dependency lists.
2 participants
This adds requirements.txt files for the complete matrix of OS and Python that we officially support.
This is the result of instantiating new virtualenv/venv on each OS, running a
pip installof each distributable in our repository, ensuring thatpip checkcame back clean, and finally runningpip freezeredirected to the appropriate location.