Add requirements.*.txt #9785
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| set -ev | ||
|
|
||
| REPO_ROOT="$(dirname ${BASH_SOURCE[0]})/../.." | ||
|
|
||
| # Install everything from our repository first. | ||
| find ${REPO_ROOT}/src -name setup.py -type f | xargs dirname | xargs pip3 install --no-deps | ||
|
|
||
| pip3 install -r ${REPO_ROOT}/src/azure-cli/requirements.py3.linux.txt | ||
|
|
||
| pip3 check | ||
|
Member
There was a problem hiding this comment. What does a failure look like here? The old script did have a decent amount of amplifying information to make the necessary course of action obvious.
Member
Author
There was a problem hiding this comment. Fair question! You can see an example of failure here: |
||
|
|
||
| python3 -m azure.cli --version | ||
|
|
||
| python3 -m azure.cli self-test | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't there be more edits to the CI where we install the CLI from the requirements file, such as before running tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, there's a family of PRs coming as I update the tests and installers. This was just to get started before I unleash all of those, to make sure we are all on the same page in terms of general approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I think the existing script is more self-documenting in terms of what someone should do to fix the issue. I don't see where it calls out which requirements file is the offending one. Also, is this only being run for Python 3 Linux since that is what the CI runs? What about the other requirements files? How will we know they need to be updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind if I address this in a follow-up? I think the points raised here are important, but I think it's more critical that I get started on overhauling the installers to use these dependency lists.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracked in #9795