Conversation
* Adding botservice package_data * Adding core package_data * Adding acr package_data * Adding monitor package_data * Adding servicefabric package_data
| 'azure-mgmt-containerinstance~=1.4', | ||
| 'azure-mgmt-containerregistry~=2.8', | ||
| 'azure-mgmt-containerservice~=5.2', | ||
| 'azure-mgmt-cosmosdb~=0.5.2', |
There was a problem hiding this comment.
This version bump was lost in the transition.
| 'azure-keyvault=1.1', | ||
| 'azure-mgmt-advisor>=2.0.1,<3.0.0', | ||
| 'azure-mgmt-applicationinsights~=0.1.1', | ||
| 'azure-mgmt-authorization~=0.50.0', |
There was a problem hiding this comment.
This version bump was lost in the transition.
| 'azure-mgmt-recoveryservicesbackup~=0.1.2', | ||
| 'azure-mgmt-redis~=6.0', | ||
| 'azure-mgmt-relay~=0.1.0', | ||
| 'azure-mgmt-reservations~=0.3.1', |
There was a problem hiding this comment.
This ~ caused and could easily cause in the future for an SDK release to suddenly break. In this case, azure-mgmt-reservations 0.3.2 bumps the API version, causing all test recordings to fail.
There was a problem hiding this comment.
Got it. The typical solution to that is to check-in a comprehensive requirements.txt. Shouldn't be too complicated for me to do, we can talk more offline.
There was a problem hiding this comment.
This test wasn't updated for a recent PR because the tests weren't being run.
tjprescott
force-pushed
the
FixTestDiscovery
branch
from
4f2ce76 to
7ee86ca
Compare
|
@marstr at this point the only thing blocking this should be the azure-mgmt-reservations issue. |
* Add Windows requirements.txt * Adding MacOS and Linux requirements.txt * Setting azure-mgmt-reservations==0.3.1 for test recording purposes * Update CI to use the new requirements.*.txt, and just make sure nothing conflicts * Install locally provided deps before falling back to PyPI * Fixing requirements.py3.linux.txt location * Don't install deps when installing from local-repository, wait to get them from requirements.txt * Remove pkg-resources line * Add verbose flag * Add az invocations on dependency check to further ensure all is well * Fixing dependencies updated in #9759 * Fixing typo
3 participants
Reopened from upstream branch to accept changes from entire team