{CI} Disable alias extension test#27717
Merged
Conversation
🔄AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
October 2023 (2023-11-14)❗ Breaking change release ❗ milestone
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
bot
requested review from
jiasli,
wangzelin007 and
yonzhan
Collaborator
|
Packaging |
bebound
changed the title
bebound
changed the title
alias extension test
evelyn-ys
approved these changes
Oct 31, 2023
wangzelin007
approved these changes
Oct 31, 2023
Member
|
Very detailed explanation. Nice work! |
jiasli
approved these changes
Oct 31, 2023
kairu-ms
reviewed
Nov 10, 2023
| # Disable k8s-extension temporarily: https://github.com/Azure/azure-cli-extensions/pull/6702 | ||
| ignore_list='azure-cli-ml fzf arcappliance arcdata connectedk8s k8s-extension' | ||
| # Disable alias temporarily: https://github.com/Azure/azure-cli/pull/27717 | ||
| ignore_list='azure-cli-ml fzf arcappliance arcdata connectedk8s k8s-extension alias' |
Contributor
There was a problem hiding this comment.
two more extensions akshybrid and azure-iot-ops
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR temporarily fixes the
Test Extensions Loading Python311error, similar PR: #20436Cause
/tools, which does not install dependency inrequirements.txt.jinja2is not insetup.py, sojinja2is not installed.aliasextension installsjinja2~=2.10, which is deprecated and it does compatible with latestmarkupsafe, which raisesImportError: cannot import name 'soft_unicode' from 'markupsafe'aosmextension requiresjinja2>=3.1.2, it tries toimport jinja2when building command tree.sys.pathone by one, soaosmimportsjinja2fromaliasextension path and fails.As
aliasextension should not install a outdatedjinja2, disable it in test soaosmcan import itsjinja2.Future work
Jinja2andMarkupSafewere introduced inrequirements.txtin #9785 and updated in #22602, but CLI does not use it.(Some scripts rely on them). We should remove it from requirements.txt to reduce package size.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.