Merged
Conversation
jiasli
approved these changes
May 25, 2022
Collaborator
|
Packaging |
Member
|
Not being able to drop Python 3.6 is really a big problem (#19858). If CentOS 7 doesn't have Python 3.7+ support, we will have to drop CentOS 7 someday. |
Contributor
|
I find these two packages is not in One interesting point is that |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Jinja2 below version 3 is not maintained. In version 3.0.3, it fixed bugs to support python 3.10 and 3.11.
The lastest version is 3.1.2, we cannot use this version because 3.1.x dropped python 3.6 support.
BTW, the version 3.0.3 already been applied in test_ref_doc.sh pipeline in #21798
Version 3.0.3 requires MarkupSafe>=2.0.
MarkupSafe 2.1.x drops python 3.6, so I bump it to version 2.0.1.
I've reviewed the usage of Jinja2 in our repo. It seems no code change required. But we still need to evaluate the impact on packaging pipeline.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.