You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Inspired by TestExtensionsLoading.
This test will check if extension's dependency is conflict with azure-cli. This should avoid issues like #24213
Currently, the extension and its dependency is installed into ~/.azure/cliextensions. The dependency error is not shown during installation.
This test also finds four incompatible extentions: attestation, cloud-service, functionapp, serial-console.
To pass the test, add them to ignore_list in the script. alias is also not compatible, but jinja is not in setup.py so it's ignored. #22602 (comment)
Hi @bebound,
I think it is necessary to find if extension's dependency is conflict with azure-cli.
I would like to ask, how did we finally solve the az interactive issue?
Whether to upgrade prompt_toolkit to 3.0.31 or uninstall prompt_toolkit directly, if it is uninstalled, how does the module using prompt_toolkit work?
What should we do after this test finding out the conflict in PR?
Is it up to the PR author to resolve the conflict or upgrade the version of the conflicting package or uninstall the conflict package directly?
For this four incompatible extentions, what are we going to do but add them to ignore_list in the script?
This test can help us to find the broken extension. How to resolve the conflict, it depends.
Make sure the dependency change is necessary and there is no alternative. Otherwise, revert the change.
If the extension is well maintained, we can notify the owner to update the extension before next azure-cli release.
If the extension is not actively developed, we may choose one of these approaches:
Fix extension by ourselves.
Add it into ignore list. (I'm not sure if we can warn user that the extension is not compatible with cli)
For your first question, the interactive issue is because azure-cli installs 3.0.31 as dependency in 2.41.0. interactive also installs 1.0.18 in ~/.azure/cliextension/interactive, but we always load azure-cli library first (#12778). prompt_toolkit 3.0.31 is loaded and interactive fails to run. In 2.42.0, we fix this by reverting the changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inspired by
TestExtensionsLoading.This test will check if extension's dependency is conflict with azure-cli. This should avoid issues like #24213
Currently, the extension and its dependency is installed into
~/.azure/cliextensions. The dependency error is not shown during installation.This test also finds four incompatible extentions:
attestation,cloud-service,functionapp,serial-console.To pass the test, add them to
ignore_listin the script.aliasis also not compatible, butjinjais not insetup.pyso it's ignored. #22602 (comment)