Merged
Conversation
(cherry picked from commit 6fcac20)
Please read [contributing guidelines](CONTRIBUTING.md) and remove this line. For audit-related pull requests, please use the [audit PR template](?expand=1&template=audit.md). (cherry picked from commit ebeac95)
Co-authored-by: Phil Windle <philip.windle@gmail.com> (cherry picked from commit 0660c61)
(cherry picked from commit 124fa94)
Adds a new flow `tryVoteWhenSyncFails` if the sequencer sync check fails and we're past the deadline for block building. This allows proposers to still vote for slashing and governance proposals even if they cannot sync to the tip of the chain.
…#17948) Block number was NOT being signed over, this meant any node could tweak it and cause receiving nodes to consider the proposal incorrect. We fix this by fetching the parent node using the last archive root (which required adding new indices to the archiver) and computing the block number by adding one to it. As for attestations, the block number was not used at all, so we could remove it. Fixes A-128
Addresses minor issues. - Adds check for chainid on the bloblib before allowing the test lookup - Removes unnecessary `RewardDistributor` storage on the rollup config (was not properly removed when the reward configuration was separated). - Return early in `RewardLib:_toShares` when result would be the same as in full execution - Removes unnecessary cast to bytes16 of value that is already bytes16 (cherry picked from commit 4d8c126)
4db94cd to
cf50621
Compare
spalladino
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR accumulates backport commits throughout the day and will be auto-merged overnight.
Latest backport: #17807 - fix: load masked values
🤖 This PR is managed automatically by the backport workflow.