Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
just-mitch
approved these changes
Oct 27, 2025
Addresses minor issues. - Adds check for chainid on the bloblib before allowing the test lookup - Removes unnecessary `RewardDistributor` storage on the rollup config (was not properly removed when the reward configuration was separated). - Return early in `RewardLib:_toShares` when result would be the same as in full execution - Removes unnecessary cast to bytes16 of value that is already bytes16
AztecBot
force-pushed
the
lh/minor-fixes
branch
from
d53e186 to
4d8c126
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
Collaborator
|
✅ Successfully cherry-picked 1 commit(s) to backport staging branch |
spalladino
added a commit
that referenced
this pull request
Oct 28, 2025
This PR accumulates backport commits throughout the day and will be auto-merged overnight. Latest backport: #17807 - fix: load masked values 🤖 This PR is managed automatically by the backport workflow. - #17785 - fix: Handle invalid ecdsa signatures - #17824 - chore: update zkpassport version to 0.10.0 - #17836 - chore: More mainnet config - #17738 - feat: coin issuer uses percentage of total supply - #17984 - chore: minor contract fixes --------- Co-authored-by: Santiago Palladino <santiago@aztec-labs.com> Co-authored-by: saleel <13466197+saleel@users.noreply.github.com> Co-authored-by: PhilWindle <60546371+PhilWindle@users.noreply.github.com> Co-authored-by: Phil Windle <philip.windle@gmail.com> Co-authored-by: LHerskind <16536249+LHerskind@users.noreply.github.com> Co-authored-by: Santiago Palladino <santiago@aztecprotocol.com>
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses minor issues.
RewardDistributorstorage on the rollup config (was not properly removed when the reward configuration was separated).RewardLib:_toShareswhen result would be the same as in full execution