fix: Do not allow txs in proposals if disableTransactions is set#17882
Merged
spalladino merged 2 commits intonextfrom Oct 23, 2025
Merged
fix: Do not allow txs in proposals if disableTransactions is set#17882spalladino merged 2 commits intonextfrom
spalladino merged 2 commits intonextfrom
Conversation
spalladino
force-pushed
the
palla/no-txs-in-proposals
branch
from
3a3e1bd to
19cd5f2
Compare
PhilWindle
approved these changes
Oct 23, 2025
spalladino
force-pushed
the
palla/no-txs-in-proposals
branch
3 times, most recently
from
856f9a8 to
cc0e194
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Reuses the `disableTransactions` flag used in p2p to also reject block proposals that have non-empty tx hashes.
spalladino
force-pushed
the
palla/no-txs-in-proposals
branch
from
cc0e194 to
88b00f7
Compare
Collaborator
|
❌ Failed to cherry-pick to |
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuses the
disableTransactionsflag used in p2p to also reject block proposals that have non-empty tx hashes.