fix: Remove block number from p2p proposals and attestations#17886
Merged
spalladino merged 1 commit intonextfrom Oct 24, 2025
Merged
fix: Remove block number from p2p proposals and attestations#17886spalladino merged 1 commit intonextfrom
spalladino merged 1 commit intonextfrom
Conversation
spalladino
added
the
ci-no-fail-fast
spalladino
force-pushed
the
palla/remove-blocknumber-from-proposals
branch
2 times, most recently
from
27635ee to
45a69a5
Compare
spalladino
force-pushed
the
palla/remove-blocknumber-from-proposals
branch
from
45a69a5 to
522beb3
Compare
PhilWindle
approved these changes
Oct 23, 2025
spalladino
force-pushed
the
palla/remove-blocknumber-from-proposals
branch
2 times, most recently
from
6d1b160 to
7209394
Compare
spalladino
force-pushed
the
palla/remove-blocknumber-from-proposals
branch
2 times, most recently
from
a07d7b5 to
2e85bce
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Block number was NOT being signed over, this meant any node could tweak it and cause receiving nodes to consider the proposal incorrect. We fix this by fetching the parent node using the last archive root (which required adding new indices to the archiver) and computing the block number by adding one to it. As for attestations, the block number was not used at all, so we could remove it.
spalladino
force-pushed
the
palla/remove-blocknumber-from-proposals
branch
from
2e85bce to
de6b4d4
Compare
Collaborator
|
❌ Failed to cherry-pick to |
spalladino
added a commit
that referenced
this pull request
Oct 24, 2025
Block number was NOT being signed over, this meant any node could tweak it and cause receiving nodes to consider the proposal incorrect. We fix this by fetching the parent node using the last archive root (which required adding new indices to the archiver) and computing the block number by adding one to it. As for attestations, the block number was not used at all, so we could remove it. Fixes A-128
spalladino
added a commit
that referenced
this pull request
Oct 24, 2025
…#17948) Block number was NOT being signed over, this meant any node could tweak it and cause receiving nodes to consider the proposal incorrect. We fix this by fetching the parent node using the last archive root (which required adding new indices to the archiver) and computing the block number by adding one to it. As for attestations, the block number was not used at all, so we could remove it. Fixes A-128
spalladino
added a commit
that referenced
this pull request
Oct 28, 2025
…#17948) Block number was NOT being signed over, this meant any node could tweak it and cause receiving nodes to consider the proposal incorrect. We fix this by fetching the parent node using the last archive root (which required adding new indices to the archiver) and computing the block number by adding one to it. As for attestations, the block number was not used at all, so we could remove it. Fixes A-128
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block number was NOT being signed over, this meant any node could tweak it and cause receiving nodes to consider the proposal incorrect. We fix this by fetching the parent node using the last archive root (which required adding new indices to the archiver) and computing the block number by adding one to it.
As for attestations, the block number was not used at all, so we could remove it.
Fixes A-128