refactor!: cleaning up our use of testWallet.getNotes(...)#17325
Merged
refactor!: cleaning up our use of testWallet.getNotes(...)#17325
testWallet.getNotes(...)#17325Conversation
This was referenced Sep 26, 2025
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
force-pushed
the
09-26-refactor_dropping_getnotes_from_testwallet
branch
from
35e9ba1 to
5d120a8
Compare
benesjan
commented
Sep 26, 2025
benesjan
commented
Sep 26, 2025
benesjan
commented
Sep 26, 2025
benesjan
commented
Sep 26, 2025
noir-projects/noir-contracts/contracts/app/crowdfunding_contract/src/main.nr
Show resolved
Hide resolved
benesjan
commented
Sep 26, 2025
noir-projects/noir-contracts/contracts/app/crowdfunding_contract/src/main.nr
Show resolved
Hide resolved
benesjan
commented
Sep 26, 2025
noir-projects/noir-contracts/contracts/app/crowdfunding_contract/src/main.nr
Show resolved
Hide resolved
benesjan
force-pushed
the
09-26-refactor_dropping_getnotes_from_testwallet
branch
from
8d133fd to
40d4375
Compare
benesjan
force-pushed
the
09-25-refactor_testwallet_api_cleanup_pt.2
branch
from
86f95ca to
273de06
Compare
AztecBot
force-pushed
the
09-25-refactor_testwallet_api_cleanup_pt.2
branch
from
273de06 to
5b593d6
Compare
Base automatically changed from
09-25-refactor_testwallet_api_cleanup_pt.2
to
next
September 29, 2025 12:33
benesjan
force-pushed
the
09-26-refactor_dropping_getnotes_from_testwallet
branch
from
40d4375 to
ca10623
Compare
benesjan
changed the title
wallet.getNotes
benesjan
changed the title
wallet.getNotestestWallet.getNotes(...)
benesjan
changed the title
testWallet.getNotes(...)testWallet.getNotes(...)
benesjan
force-pushed
the
09-26-refactor_dropping_getnotes_from_testwallet
branch
from
bd5f237 to
cef213a
Compare
benesjan
commented
Sep 29, 2025
| return decodedEvents; | ||
| } | ||
|
|
||
| async resetNoteSyncData() { |
Contributor
Author
There was a problem hiding this comment.
This was unused so I dropped it. It's only used by the internal PXE synchronizer so it shouldn't be exposed.
Contributor
Contributor
There was a problem hiding this comment.
I don't think anyone is using it and invoking the method won't get you out of #15753, because the problem is that your index "got outside" of the window. Resetting them won't unstuck you (nor cleaning PXEs db entirely)
Contributor
Author
There was a problem hiding this comment.
In that case will not revert this change and all of Nico's feedback on this PR is now addressed (was careful with the commit history so seeing changes since last review should work).
benesjan
commented
Sep 29, 2025
yarn-project/end-to-end/src/e2e_blacklist_token_contract/minting.test.ts
Show resolved
Hide resolved
nventuro
reviewed
Sep 29, 2025
Contributor
nventuro
left a comment
nventuro
left a comment
There was a problem hiding this comment.
Lovely, thanks a lot for the careful considerations
noir-projects/noir-contracts/contracts/app/crowdfunding_contract/src/main.nr
Show resolved
Hide resolved
| return decodedEvents; | ||
| } | ||
|
|
||
| async resetNoteSyncData() { |
Contributor
This was referenced Sep 30, 2025
nventuro
approved these changes
Sep 30, 2025
AztecBot
force-pushed
the
09-26-refactor_dropping_getnotes_from_testwallet
branch
from
4b1c2cf to
c18f5d1
Compare
AztecBot
force-pushed
the
09-26-refactor_dropping_getnotes_from_testwallet
branch
from
c18f5d1 to
b4fea5d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
benesjan
force-pushed
the
09-26-refactor_dropping_getnotes_from_testwallet
branch
from
b4fea5d to
a185f09
Compare
In this PR I replace incorrect use of the `testWallet.getNotes(...)` debugging function by implementing corresponding utility functions and I drop the Aztec Cheatcodes class as it became unused. Nuked the testing with Aztec.js section of docs as it became so stale to the point of being detrimental. Asked devrel and they prefer me rewriting it so I will do that in a followup PR.
AztecBot
force-pushed
the
09-26-refactor_dropping_getnotes_from_testwallet
branch
from
5467aab to
079f99d
Compare
auto-merge was automatically disabled
September 30, 2025 14:48
Pull Request is not mergeable
benesjan
deleted the
09-26-refactor_dropping_getnotes_from_testwallet
branch
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I replace incorrect use of the
testWallet.getNotes(...)debugging function by implementing corresponding utility functions and I drop the Aztec Cheatcodes class as it became unused.Nuked the testing with Aztec.js section of docs as it became so stale to the point of being detrimental. Asked devrel and they prefer me rewriting it so I will do that in a followup PR.