Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Sep 25, 2025
benesjan
changed the base branch from
09-25-refactor_testwallet_api_cleanup
to
graphite-base/17295
benesjan
force-pushed
the
09-25-refactor_testwallet_api_cleanup_pt.2
branch
from
e3b44a5 to
193cfac
Compare
benesjan
changed the base branch from
graphite-base/17295
to
09-25-refactor_merging_pxe_interface_and_its_implementation
benesjan
force-pushed
the
09-25-refactor_testwallet_api_cleanup_pt.2
branch
3 times, most recently
from
4413d51 to
206c56d
Compare
benesjan
force-pushed
the
09-25-refactor_merging_pxe_interface_and_its_implementation
branch
from
a7b9b55 to
62ef624
Compare
benesjan
force-pushed
the
09-25-refactor_testwallet_api_cleanup_pt.2
branch
from
206c56d to
48e0395
Compare
benesjan
force-pushed
the
09-25-refactor_merging_pxe_interface_and_its_implementation
branch
from
62ef624 to
3c3c721
Compare
benesjan
force-pushed
the
09-25-refactor_testwallet_api_cleanup_pt.2
branch
4 times, most recently
from
e5a2094 to
78097e5
Compare
benesjan
force-pushed
the
09-25-refactor_merging_pxe_interface_and_its_implementation
branch
from
e839241 to
3c4c58e
Compare
benesjan
force-pushed
the
09-25-refactor_testwallet_api_cleanup_pt.2
branch
from
78097e5 to
de8c543
Compare
benesjan
commented
Sep 26, 2025
Comment on lines
+112
to
+114
| get address() { | ||
| return this.instance.address; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
As discussed in DMs, this getter just looks nicer in code.
Contributor
There was a problem hiding this comment.
I'll probably kill the one above soon, since we're "starting from scratch" on wallet apis
benesjan
commented
Sep 26, 2025
| --bot.senderSalt <value> ($BOT_ACCOUNT_SALT) | ||
| The salt to use to deploys the sender account. | ||
|
|
||
| --bot.recipientEncryptionSecret <value> (default: [Redacted]) ($BOT_RECIPIENT_ENCRYPTION_SECRET) |
Contributor
Author
There was a problem hiding this comment.
Alex confirmed that dropping this and just using arbitrary recipient is fine.
AztecBot
force-pushed
the
09-25-refactor_merging_pxe_interface_and_its_implementation
branch
from
1737485 to
89729a0
Compare
Base automatically changed from
09-25-refactor_merging_pxe_interface_and_its_implementation
to
next
September 26, 2025 09:52
benesjan
force-pushed
the
09-25-refactor_testwallet_api_cleanup_pt.2
branch
from
5ec271b to
e50e100
Compare
benesjan
commented
Sep 26, 2025
| @@ -189,7 +189,7 @@ No correctness is guaranteed on the result of `simulate`! Correct execution is e | |||
|
|
|||
| This creates and returns a transaction request, which includes proof of correct private execution and side-effects. The request is not broadcast however, and no gas is spent. It is typically used in testing contexts to inspect transaction parameters or to check for execution failure. | |||
|
|
|||
| #include_code local-tx-fails /yarn-project/end-to-end/src/guides/dapp_testing.test.ts typescript | |||
| #include_code local-tx-fails /yarn-project/end-to-end/src/e2e_crowdfunding_and_claim.test.ts typescript | |||
Contributor
Author
There was a problem hiding this comment.
Dropped the dapp_testing.test.ts because it was stale and basically no longer used in docs. This was the only occurrence in docs.
What motivated me to drop it is that we directly obtained there the notes from wallet and that is deprecated.
benesjan
commented
Sep 26, 2025
Comment on lines
+98
to
+101
| await wallet.registerKeysForEscrowContract( | ||
| crowdfundingSecretKey, | ||
| await computePartialAddress(crowdfundingInstance), | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
Renamed the problematic function to make it less cancerous before it gets completely nuked.
benesjan
commented
Sep 26, 2025
|
|
||
| it('reuses the same account and token contract', async () => { | ||
| const { defaultAccountAddress, token, recipient } = bot; | ||
| it('reuses the same token contract', async () => { |
Contributor
Author
There was a problem hiding this comment.
Recipient is no longer stable across bot instantiations but Alex said it doesn't matter.
Thunkar
reviewed
Sep 29, 2025
| * Returns the PXE. | ||
| * @deprecated This is only used by account manager to because there we call registerAccount. This can be dropped | ||
| * once we allow Wallet.registerContract accepts secretKey and partialAddress on the input. | ||
| */ |
Contributor
There was a problem hiding this comment.
I'm killing this next, so we should be good
Thunkar
approved these changes
Sep 29, 2025
benesjan
force-pushed
the
09-25-refactor_testwallet_api_cleanup_pt.2
branch
from
86f95ca to
273de06
Compare
Continuation of #17283. Changes explained with comments in the code.
AztecBot
force-pushed
the
09-25-refactor_testwallet_api_cleanup_pt.2
branch
from
273de06 to
5b593d6
Compare
auto-merge was automatically disabled
September 29, 2025 12:32
Pull Request is not mergeable
This was referenced Sep 30, 2025
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #17283. Changes explained with comments in the code.