refactor: merging PXE interface and its implementation#17303
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
commented
Sep 25, 2025
benesjan
commented
Sep 25, 2025
|
|
||
| ## Usage | ||
|
|
||
| To use `aztec-cli`, open a terminal or command prompt and run the `aztec-cli` command followed by the desired command and its options. |
Contributor
Author
There was a problem hiding this comment.
This was super stale so I just instructed reader to print out aztec-cli --help
benesjan
commented
Sep 25, 2025
benesjan
commented
Sep 25, 2025
| import type { AbiType } from './abi.js'; | ||
| import type { EventSelector } from './event_selector.js'; | ||
|
|
||
| export type EventMetadataDefinition = { |
Contributor
Author
There was a problem hiding this comment.
Moved here from PXE interface as it's imported by both wallet and pxe
benesjan
commented
Sep 25, 2025
| import type { ContractArtifact } from '../abi/abi.js'; | ||
| import type { ContractClassWithId } from './interfaces/contract_class.js'; | ||
|
|
||
| export interface ContractClassMetadata { |
Contributor
Author
There was a problem hiding this comment.
Moved here from PXE interface as it's imported by both wallet and pxe
benesjan
commented
Sep 25, 2025
| @@ -0,0 +1,7 @@ | |||
| import type { ContractInstanceWithAddress } from './interfaces/contract_instance.js'; | |||
|
|
|||
| export interface ContractMetadata { | |||
Contributor
Author
There was a problem hiding this comment.
Moved here from PXE interface as it's imported by both wallet and pxe
benesjan
force-pushed
the
09-25-refactor_testwallet_api_cleanup
branch
from
ad7f32e to
3413e33
Compare
benesjan
force-pushed
the
09-25-refactor_merging_pxe_interface_and_its_implementation
branch
2 times, most recently
from
62ef624 to
3c3c721
Compare
AztecBot
force-pushed
the
09-25-refactor_testwallet_api_cleanup
branch
from
d7dd3d0 to
94ae864
Compare
Base automatically changed from
09-25-refactor_testwallet_api_cleanup
to
next
September 26, 2025 07:29
benesjan
force-pushed
the
09-25-refactor_merging_pxe_interface_and_its_implementation
branch
from
e839241 to
3c4c58e
Compare
Thunkar
reviewed
Sep 26, 2025
| import type { ExecutionPayload } from '@aztec/entrypoints/payload'; | ||
| import { Fq, Fr } from '@aztec/foundation/fields'; | ||
| import type { PXE } from '@aztec/pxe'; | ||
| import type { PXE } from '@aztec/pxe/server'; |
Contributor
There was a problem hiding this comment.
Even if just a type import, prefer /client/lazy ones to be safe when these can be imported from the browser
Thunkar
approved these changes
Sep 26, 2025
There will always be only 1 implementation of the PXE interface so it didn't really make sense to have it. In this PR I merged it with PXEService (i.e. copy over the docs) and I rename all the occurrences of PXE Service just as PXE. Now that there is no JSON RPC PXE server that name was misleading. ## Staring into the abyss Unfortunately, there is a downside to this PR and that is that I needed to drop the proper `PXE` type from `BaseWallet` as Aztec.js cannot import pxe package due to a circular dependency: `pxe --> bbprover --> aztec.js --> pxe` For this reason now there is the pxe arg defined as `pxe: any`. This will get resolved once `@aztec/wallet-sdk` package is introduced.
AztecBot
force-pushed
the
09-25-refactor_merging_pxe_interface_and_its_implementation
branch
from
1737485 to
89729a0
Compare
benesjan
deleted the
09-25-refactor_merging_pxe_interface_and_its_implementation
branch
This was referenced Sep 26, 2025
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There will always be only 1 implementation of the PXE interface so it didn't really make sense to have it. In this PR I merged it with PXEService (i.e. copy over the docs) and I rename all the occurrences of PXE Service just as PXE. Now that there is no JSON RPC PXE server that name was misleading.
Staring into the abyss
Unfortunately, there is a downside to this PR and that is that I needed to drop the proper
PXEtype fromBaseWalletas Aztec.js cannot import pxe package due to a circular dependency:pxe --> bbprover --> aztec.js --> pxeFor this reason now there is the pxe arg defined as
pxe: any. This will get resolved once@aztec/wallet-sdkpackage is introduced.