refactor: TestWallet API cleanup pt. 1#17283
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
commented
Sep 25, 2025
| - `--sponsored-fpc`: Populate genesis state with a testing sponsored FPC contract | ||
| - `--accelerated-test-deployments`: Fire and forget deployment transactions, use in testing only (default: false) | ||
|
|
||
| ### deploy-l1-verifier |
Contributor
Author
There was a problem hiding this comment.
This command doesn't exist on the cli.
benesjan
commented
Sep 25, 2025
| - `--public-deploy`: Publishes the account contract instance (and the class, if needed). Needed if the contract contains public functions. | ||
| - `-p, --public-key <string>`: Public key that identifies a private signing key stored outside of the wallet. Used for ECDSA SSH accounts over the secp256r1 curve. | ||
| - `-n, --node-url <string>`: URL of the PXE (default: "http://host.docker.internal:8080") | ||
| - `-n, --node-url <string>`: URL of Aztec Node (default: "http://host.docker.internal:8080") |
Contributor
Author
There was a problem hiding this comment.
Forgot to update in the last PR. These references seems like a pretty bad thing to have given that aztec --help is available and there it will not become stale.
benesjan
commented
Sep 25, 2025
| */ | ||
| public async register(): Promise<AccountWithSecretKey> { | ||
| await this.pxe.registerContract({ | ||
| await this.wallet.registerContract({ |
Contributor
Author
There was a problem hiding this comment.
Random change when I was investigating what is remaining from allowing me to drop the ugly getPxe method on test wallet. That function can be dropped once we allow Wallet.registerContract to accept secretKey and partialAddress on the input.
benesjan
commented
Sep 25, 2025
| const receipt = await aztecNode.getTxReceipt(txHash); | ||
| return receipt.status; | ||
| } else { | ||
| await inspectTx(wallet, aztecNode, txHash, log, { includeBlockInfo: true }); |
Contributor
Author
There was a problem hiding this comment.
Just did a minor cleanup of this func.
benesjan
commented
Sep 25, 2025
| * When this flag is true, simulateTx constructs a request using a fake account (and accepts contract overrides | ||
| * on the input) and the PXE emulates kernel effects without generating kernel witnesses. When false, simulateTx | ||
| * defers to the standard simulation path. | ||
| */ |
Contributor
Author
There was a problem hiding this comment.
Docs based on comment Grego sent on slack.
Grego pls check it's no ambiguous.
Contributor
There was a problem hiding this comment.
The gas estimations not being accurate is not a given, I wouldn't say that in the comment. We aim for them to be accurate and usable, and for now they are
benesjan
changed the title
benesjan
force-pushed
the
09-25-refactor_testwallet_api_cleanup
branch
from
5d56948 to
ad7f32e
Compare
benesjan
commented
Sep 25, 2025
| const [secret, messageLeafIndex] = await bridgeL1FeeJuice( | ||
| amount, | ||
| recipient, | ||
| wallet, |
Contributor
Author
There was a problem hiding this comment.
Wallet no longer needs to be passed in as we can just obtain all the necessary info from node.
Thunkar
reviewed
Sep 26, 2025
| executionPayload: ExecutionPayload, | ||
| opts: SimulateMethodOptions, | ||
| ): Promise<TxSimulationResult> { | ||
| // In simulated-simulation mode we emulate kernel logic in TS. This is fast but can skew gas, |
Contributor
There was a problem hiding this comment.
I just dropped this from my current PR, comment is unnecessary
benesjan
force-pushed
the
09-25-refactor_testwallet_api_cleanup
branch
from
ad7f32e to
3413e33
Compare
Thunkar
approved these changes
Sep 26, 2025
Followup work of #17228 In this PR I drop `getPXEInfo` and `getContracts` from `TestWallet` + add random docs improvements. `getPXEInfo` was just a tech debt as it was only used to check if node has the same protocol contract addresses which is quite non-sensical because those addresses are no literally 1, 2, 3, 4, 5... I assume this check is there from time when they didn't have these hardcoded addresses. `getContracts` was used just in one test and the check there was not really that important so I just dropped it.
AztecBot
force-pushed
the
09-25-refactor_testwallet_api_cleanup
branch
from
d7dd3d0 to
94ae864
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
AztecBot
pushed a commit
that referenced
this pull request
Sep 29, 2025
Continuation of #17283. Changes explained with comments in the code.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 29, 2025
Continuation of #17283. Changes explained with comments in the code.
This was referenced Sep 30, 2025
mralj
pushed a commit
that referenced
this pull request
Oct 13, 2025
Continuation of #17283. Changes explained with comments in the code.
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup work of #17228
In this PR I drop
getPXEInfoandgetContractsfromTestWallet+ add random docs improvements.getPXEInfowas just a tech debt as it was only used to check if node has the same protocol contract addresses which is quite non-sensical because those addresses are no literally 1, 2, 3, 4, 5... I assume this check is there from time when they didn't have these hardcoded addresses.getContractswas used just in one test and the check there was not really that important so I just dropped it.