Skip to content

refactor: renaming unconstrained function as utility in TS#13249

Merged
charlielye merged 8 commits intomasterfrom
04-02-refactor_unconstrainedexecutionoracle_--_utilityexecutionoracle
Apr 4, 2025
Merged

refactor: renaming unconstrained function as utility in TS#13249
charlielye merged 8 commits intomasterfrom
04-02-refactor_unconstrainedexecutionoracle_--_utilityexecutionoracle

Conversation

@benesjan
Copy link
Contributor

@benesjan benesjan commented Apr 2, 2025

Partially addresses #12743 (partially as the rest will be addressed in PRs up the stacks)

In this PR I rename occurrences of unconstrained to utility in our TS codebase.

There are still missing some renamings on ContractClassRegister and renamings of the related constants. That will be done in a separate PR.

Copy link
Contributor Author

benesjan commented Apr 2, 2025

@benesjan benesjan force-pushed the 04-02-refactor_unconstrainedexecutionoracle_--_utilityexecutionoracle branch from fe90087 to 2e3073c Compare April 2, 2025 22:06
@benesjan benesjan force-pushed the 04-02-refactorunsconstrainedcontext_--_utilitycontext branch from c08fa9b to b2841a7 Compare April 2, 2025 22:06
@benesjan benesjan changed the base branch from 04-02-refactorunsconstrainedcontext_--_utilitycontext to graphite-base/13249 April 2, 2025 23:53
@benesjan benesjan force-pushed the graphite-base/13249 branch from b2841a7 to 1a7a6c2 Compare April 2, 2025 23:53
@benesjan benesjan force-pushed the 04-02-refactor_unconstrainedexecutionoracle_--_utilityexecutionoracle branch from f377075 to 3d52ce1 Compare April 2, 2025 23:53
@benesjan benesjan changed the base branch from graphite-base/13249 to 04-02-chore_minor_simulator_utils_cleanup April 2, 2025 23:53
@benesjan benesjan changed the title refactor: UnconstrainedExecutionOracle --> UtilityExecutionOracle refactor: renaming unconstrained function as utility in TS Apr 2, 2025
@benesjan benesjan added the ci-full Run all master checks. label Apr 3, 2025
@benesjan benesjan marked this pull request as ready for review April 3, 2025 00:03
@benesjan benesjan marked this pull request as draft April 3, 2025 00:05
@benesjan benesjan force-pushed the 04-02-chore_minor_simulator_utils_cleanup branch from 1a7a6c2 to cfdf034 Compare April 3, 2025 00:05
@benesjan benesjan force-pushed the 04-02-refactor_unconstrainedexecutionoracle_--_utilityexecutionoracle branch from 3d52ce1 to 777e01c Compare April 3, 2025 00:05
@benesjan benesjan marked this pull request as ready for review April 3, 2025 00:06
Copy link
Contributor

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benesjan benesjan force-pushed the 04-02-chore_minor_simulator_utils_cleanup branch from cfdf034 to afac202 Compare April 3, 2025 02:34
@benesjan benesjan force-pushed the 04-02-refactor_unconstrainedexecutionoracle_--_utilityexecutionoracle branch from 777e01c to b3fa010 Compare April 3, 2025 02:34
@benesjan benesjan marked this pull request as draft April 3, 2025 02:47
@benesjan benesjan force-pushed the 04-02-refactor_unconstrainedexecutionoracle_--_utilityexecutionoracle branch from b3fa010 to d8790ab Compare April 3, 2025 02:47
@benesjan benesjan force-pushed the 04-02-chore_minor_simulator_utils_cleanup branch from afac202 to 7f68fa4 Compare April 3, 2025 02:47
@benesjan benesjan force-pushed the 04-02-refactor_unconstrainedexecutionoracle_--_utilityexecutionoracle branch from d8790ab to 62fe983 Compare April 3, 2025 15:08
@benesjan benesjan force-pushed the 04-02-chore_minor_simulator_utils_cleanup branch 2 times, most recently from 52b19ed to 16c7fae Compare April 3, 2025 18:30
@benesjan benesjan force-pushed the 04-02-chore_minor_simulator_utils_cleanup branch from a1aef8e to 59a5129 Compare April 4, 2025 01:08
@benesjan benesjan marked this pull request as ready for review April 4, 2025 01:08
Copy link
Contributor Author

benesjan commented Apr 4, 2025

Merge activity

@benesjan benesjan marked this pull request as draft April 4, 2025 01:41
@benesjan benesjan force-pushed the 04-02-refactor_unconstrainedexecutionoracle_--_utilityexecutionoracle branch from 4a6bf37 to 66ca75d Compare April 4, 2025 02:06
@benesjan benesjan force-pushed the 04-02-chore_minor_simulator_utils_cleanup branch from 59a5129 to 0fe5912 Compare April 4, 2025 02:06
Base automatically changed from 04-02-chore_minor_simulator_utils_cleanup to master April 4, 2025 03:05
@benesjan benesjan force-pushed the 04-02-refactor_unconstrainedexecutionoracle_--_utilityexecutionoracle branch from 66ca75d to b28d778 Compare April 4, 2025 03:07
@benesjan benesjan marked this pull request as ready for review April 4, 2025 03:07
@benesjan benesjan enabled auto-merge April 4, 2025 03:07
@benesjan benesjan added this pull request to the merge queue Apr 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 4, 2025
@benesjan benesjan added this pull request to the merge queue Apr 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 4, 2025
@benesjan benesjan added this pull request to the merge queue Apr 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 4, 2025
@charlielye charlielye added this pull request to the merge queue Apr 4, 2025
Merged via the queue into master with commit 34d03bb Apr 4, 2025
12 of 14 checks passed
@charlielye charlielye deleted the 04-02-refactor_unconstrainedexecutionoracle_--_utilityexecutionoracle branch April 4, 2025 08:21
github-merge-queue bot pushed a commit that referenced this pull request Apr 4, 2025
🤖 I have created a new Aztec Packages release
---


##
[0.84.0](v0.83.1...v0.84.0)
(2025-04-04)


### ⚠ BREAKING CHANGES

* `UnsconstrainedContext` --> `UtilityContext`
([#13246](#13246))
* `#[utility]` function
([#13243](#13243))
* Validate public setup fns and gas in p2p
([#13154](#13154))

### Features

* `#[utility]` function
([#13243](#13243))
([945ffa2](945ffa2))
* **avm:** tx hint init
([#13218](#13218))
([60a1a92](60a1a92))
* Remove 4 byte metadata from bb-produced proof
([#13231](#13231))
([0dcc915](0dcc915))
* To enable better ci dashboard.
([#13272](#13272))
([61c6375](61c6375))


### Bug Fixes

* **avm:** fix lookup builder and FF hashing
([#13263](#13263))
([2633856](2633856))
* ci3-external concurrency bug, reduce grind set
([2c5e830](2c5e830)),
closes
[#13285](#13285)
* ci3-external.yml
([#13291](#13291))
([6ad68ed](6ad68ed))
* Validate public setup fns and gas in p2p
([#13154](#13154))
([1ef4add](1ef4add)),
closes
[#10958](#10958)


### Miscellaneous

* `UnsconstrainedContext` --> `UtilityContext`
([#13246](#13246))
([69df86f](69df86f))
* add some PrivateSet tests
([#13270](#13270))
([bd9e690](bd9e690))
* bump full prover test to 32 cores. hoping to boost speed.
([#13293](#13293))
([c8e95dd](c8e95dd))
* deflake p2p reqresp test
([#13271](#13271))
([b9164fa](b9164fa))
* don't dump on fail. click the link instead.
([#13292](#13292))
([ba0fb4d](ba0fb4d))
* flake
([#13277](#13277))
([62c32eb](62c32eb))
* make rahul happy with migration notes
([#13255](#13255))
([3dd75a6](3dd75a6))
* minor simulator utils cleanup
([#13250](#13250))
([8a622c9](8a622c9))
* move a couple of `SharedMutableValues` functions outside of impl
([#13283](#13283))
([df9a40c](df9a40c))
* nuking debug-only logger and various unused functionality in
`foundation`
([#13187](#13187))
([2d38e60](2d38e60))
* prevent eth devnet config contention in ci
([#13260](#13260))
([1581836](1581836))
* renaming unconstrained function as utility in TS
([#13249](#13249))
([34d03bb](34d03bb))
* replace relative paths to noir-protocol-circuits
([b5b99f8](b5b99f8))
* Speed up note hashes test
([#13282](#13282))
([ad23358](ad23358))
* update gov and proposer configs
([#13281](#13281))
([e1a5be3](e1a5be3))
* update slashing test port
([#13274](#13274))
([9a1ddc5](9a1ddc5))
* Want to fail fast on test runs and the wider ci run.
([#13258](#13258))
([f0553b8](f0553b8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-full Run all master checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants