feat: Remove 4 byte metadata from bb-produced proof#13231
Merged
lucasxia01 merged 11 commits intomasterfrom Apr 3, 2025
Merged
feat: Remove 4 byte metadata from bb-produced proof#13231lucasxia01 merged 11 commits intomasterfrom
lucasxia01 merged 11 commits intomasterfrom
Conversation
lucasxia01
commented
Apr 2, 2025
| .action((args) => verifyProof(args)); | ||
| .action(async (args) => { | ||
| const result = await verifyProof(args); | ||
| process.exit(result ? 0 : 1); |
Contributor
Author
There was a problem hiding this comment.
had to fix this as it wasn't exiting with the right exit code based on verified. It was just always exiting with 0, so tests would pass even if verified was false.
iakovenkos
reviewed
Apr 3, 2025
|
|
||
| template <typename Flavor> | ||
| bool _verify(const bool honk_recursion_2, | ||
| bool _verify(const bool ipa_accumulation, |
Contributor
There was a problem hiding this comment.
wow honk_recursion_2, would've never guessed without looking into the method body that it stands for ipa_accumulation, thanks for renaming!
iakovenkos
approved these changes
Apr 3, 2025
Contributor
iakovenkos
left a comment
iakovenkos
left a comment
There was a problem hiding this comment.
looks great, thanks for the clean-up
lucasxia01
deleted the
lx/remove-4-byte-serialization-metadata-from-proof
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 4, 2025
🤖 I have created a new Aztec Packages release --- ## [0.84.0](v0.83.1...v0.84.0) (2025-04-04) ### ⚠ BREAKING CHANGES * `UnsconstrainedContext` --> `UtilityContext` ([#13246](#13246)) * `#[utility]` function ([#13243](#13243)) * Validate public setup fns and gas in p2p ([#13154](#13154)) ### Features * `#[utility]` function ([#13243](#13243)) ([945ffa2](945ffa2)) * **avm:** tx hint init ([#13218](#13218)) ([60a1a92](60a1a92)) * Remove 4 byte metadata from bb-produced proof ([#13231](#13231)) ([0dcc915](0dcc915)) * To enable better ci dashboard. ([#13272](#13272)) ([61c6375](61c6375)) ### Bug Fixes * **avm:** fix lookup builder and FF hashing ([#13263](#13263)) ([2633856](2633856)) * ci3-external concurrency bug, reduce grind set ([2c5e830](2c5e830)), closes [#13285](#13285) * ci3-external.yml ([#13291](#13291)) ([6ad68ed](6ad68ed)) * Validate public setup fns and gas in p2p ([#13154](#13154)) ([1ef4add](1ef4add)), closes [#10958](#10958) ### Miscellaneous * `UnsconstrainedContext` --> `UtilityContext` ([#13246](#13246)) ([69df86f](69df86f)) * add some PrivateSet tests ([#13270](#13270)) ([bd9e690](bd9e690)) * bump full prover test to 32 cores. hoping to boost speed. ([#13293](#13293)) ([c8e95dd](c8e95dd)) * deflake p2p reqresp test ([#13271](#13271)) ([b9164fa](b9164fa)) * don't dump on fail. click the link instead. ([#13292](#13292)) ([ba0fb4d](ba0fb4d)) * flake ([#13277](#13277)) ([62c32eb](62c32eb)) * make rahul happy with migration notes ([#13255](#13255)) ([3dd75a6](3dd75a6)) * minor simulator utils cleanup ([#13250](#13250)) ([8a622c9](8a622c9)) * move a couple of `SharedMutableValues` functions outside of impl ([#13283](#13283)) ([df9a40c](df9a40c)) * nuking debug-only logger and various unused functionality in `foundation` ([#13187](#13187)) ([2d38e60](2d38e60)) * prevent eth devnet config contention in ci ([#13260](#13260)) ([1581836](1581836)) * renaming unconstrained function as utility in TS ([#13249](#13249)) ([34d03bb](34d03bb)) * replace relative paths to noir-protocol-circuits ([b5b99f8](b5b99f8)) * Speed up note hashes test ([#13282](#13282)) ([ad23358](ad23358)) * update gov and proposer configs ([#13281](#13281)) ([e1a5be3](e1a5be3)) * update slashing test port ([#13274](#13274)) ([9a1ddc5](9a1ddc5)) * Want to fail fast on test runs and the wider ci run. ([#13258](#13258)) ([f0553b8](f0553b8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes AztecProtocol/barretenberg#1312.
Removes the 4 byte metadata from proof and public inputs produced from the
to_buffer</*include_size=*/true>()function. We are able to serialize and deserialize without this metadata by use many_from_buffer for deserialization.The result is that we get to remove a lot of ugly if statements and weird proof parsing based on the metadata.