chore: updated docs#13248
Closed
benesjan wants to merge 3 commits into04-03-refactor_renaming_unconstrained_to_utility_in_registererfrom
Closed
chore: updated docs#13248benesjan wants to merge 3 commits into04-03-refactor_renaming_unconstrained_to_utility_in_registererfrom
benesjan wants to merge 3 commits into04-03-refactor_renaming_unconstrained_to_utility_in_registererfrom
Conversation
This was referenced Apr 2, 2025
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
changed the base branch from
04-02-refactorunsconstrainedcontext_--_utilitycontext
to
graphite-base/13248
benesjan
force-pushed
the
04-02-chore_updated_docs
branch
from
ada31fe to
83fd985
Compare
benesjan
changed the base branch from
graphite-base/13248
to
04-02-refactor_unconstrainedexecutionoracle_--_utilityexecutionoracle
benesjan
force-pushed
the
04-02-chore_updated_docs
branch
from
83fd985 to
72bab60
Compare
benesjan
force-pushed
the
04-02-refactor_unconstrainedexecutionoracle_--_utilityexecutionoracle
branch
from
fe90087 to
2e3073c
Compare
benesjan
force-pushed
the
04-02-chore_updated_docs
branch
2 times, most recently
from
7363601 to
7f42a38
Compare
benesjan
force-pushed
the
04-02-refactor_unconstrainedexecutionoracle_--_utilityexecutionoracle
branch
2 times, most recently
from
3d52ce1 to
777e01c
Compare
benesjan
force-pushed
the
04-02-chore_updated_docs
branch
from
7f42a38 to
533ee4a
Compare
benesjan
force-pushed
the
04-02-refactor_unconstrainedexecutionoracle_--_utilityexecutionoracle
branch
from
777e01c to
b3fa010
Compare
benesjan
force-pushed
the
04-02-chore_updated_docs
branch
from
533ee4a to
2c7aa06
Compare
benesjan
force-pushed
the
04-02-refactor_unconstrainedexecutionoracle_--_utilityexecutionoracle
branch
from
b3fa010 to
d8790ab
Compare
benesjan
force-pushed
the
04-02-chore_updated_docs
branch
2 times, most recently
from
01cda96 to
740d2d1
Compare
benesjan
force-pushed
the
04-02-refactor_unconstrainedexecutionoracle_--_utilityexecutionoracle
branch
from
d8790ab to
62fe983
Compare
benesjan
force-pushed
the
04-02-chore_updated_docs
branch
from
740d2d1 to
bbec5f3
Compare
benesjan
force-pushed
the
04-02-refactor_unconstrainedexecutionoracle_--_utilityexecutionoracle
branch
from
62fe983 to
4d8dbaf
Compare
benesjan
force-pushed
the
04-02-chore_updated_docs
branch
2 times, most recently
from
6250c84 to
f63fe85
Compare
benesjan
changed the base branch from
04-02-refactor_unconstrainedexecutionoracle_--_utilityexecutionoracle
to
graphite-base/13248
benesjan
force-pushed
the
04-02-chore_updated_docs
branch
2 times, most recently
from
cfe9160 to
0c62bbc
Compare
benesjan
force-pushed
the
04-02-chore_updated_docs
branch
from
0c62bbc to
1096a2a
Compare
benesjan
changed the base branch from
graphite-base/13248
to
04-03-refactor_renaming_unconstrained_to_utility_in_registerer
benesjan
force-pushed
the
04-03-refactor_renaming_unconstrained_to_utility_in_registerer
branch
from
0d375f2 to
4e15c9c
Compare
benesjan
force-pushed
the
04-02-chore_updated_docs
branch
2 times, most recently
from
14a1324 to
b6d8d68
Compare
benesjan
force-pushed
the
04-03-refactor_renaming_unconstrained_to_utility_in_registerer
branch
from
4e15c9c to
7c5ea5e
Compare
benesjan
force-pushed
the
04-02-chore_updated_docs
branch
2 times, most recently
from
d1917ba to
401a7cb
Compare
benesjan
force-pushed
the
04-03-refactor_renaming_unconstrained_to_utility_in_registerer
branch
2 times, most recently
from
adefe05 to
eaa79d3
Compare
benesjan
force-pushed
the
04-02-chore_updated_docs
branch
2 times, most recently
from
2f14438 to
1c37bfa
Compare
benesjan
force-pushed
the
04-03-refactor_renaming_unconstrained_to_utility_in_registerer
branch
from
eaa79d3 to
f8dc57f
Compare
benesjan
force-pushed
the
04-02-chore_updated_docs
branch
from
1c37bfa to
6a9309b
Compare
benesjan
force-pushed
the
04-03-refactor_renaming_unconstrained_to_utility_in_registerer
branch
from
f8dc57f to
af15b61
Compare
benesjan
force-pushed
the
04-02-chore_updated_docs
branch
from
6a9309b to
fb275c9
Compare
sklppy88
approved these changes
Apr 4, 2025
| Note that individual public functions are not first-class citizens in the protocol, so the contract entire public function bytecode is stored in the class, unlike private or unconstrained functions which are differentiated individual circuits recognized by the protocol. | ||
| Note that individual public functions are not first-class citizens in the protocol, so the contract entire public function bytecode is stored in the class, unlike private or utility functions which are differentiated individual circuits recognized by the protocol. | ||
|
|
||
| As for unconstrained functions, these are not used standalone within the protocol. They are either inlined within private functions, or called from a PXE as _getters_ for a contract. Calling from a private function to an unconstrained one in a different contract is forbidden, since the caller would have no guarantee of the code run by the callee. Considering this, unconstrained functions are not part of a contract class at the protocol level. |
Contributor
There was a problem hiding this comment.
Unrelated to your pr but this page is confusing
…ocumentation and codebase
benesjan
force-pushed
the
04-02-chore_updated_docs
branch
from
fb275c9 to
530a5c6
Compare
benesjan
force-pushed
the
04-03-refactor_renaming_unconstrained_to_utility_in_registerer
branch
from
4f01499 to
1b6bff0
Compare
Contributor
|
Superceded by #13310. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 8, 2025
Replacement for #13248 to get it out of the graphite stack. This PR updates mentions of top-level unconstrained contract fns for the new 'utility' term. Some instances may be missing, but I think we covered the vast majority of it. I also updated language in some parts were explanations were outdated, and tried to remove bits that conflated Noir unconstrained functions and utility functions. We'll likely want to expand on this given the apparent confusion. --------- Co-authored-by: benesjan <janbenes1234@gmail.com>
AztecBot
pushed a commit
to AztecProtocol/aztec-nr
that referenced
this pull request
Apr 9, 2025
Replacement for AztecProtocol/aztec-packages#13248 to get it out of the graphite stack. This PR updates mentions of top-level unconstrained contract fns for the new 'utility' term. Some instances may be missing, but I think we covered the vast majority of it. I also updated language in some parts were explanations were outdated, and tried to remove bits that conflated Noir unconstrained functions and utility functions. We'll likely want to expand on this given the apparent confusion. --------- Co-authored-by: benesjan <janbenes1234@gmail.com>
signorecello
pushed a commit
that referenced
this pull request
Apr 9, 2025
Replacement for #13248 to get it out of the graphite stack. This PR updates mentions of top-level unconstrained contract fns for the new 'utility' term. Some instances may be missing, but I think we covered the vast majority of it. I also updated language in some parts were explanations were outdated, and tried to remove bits that conflated Noir unconstrained functions and utility functions. We'll likely want to expand on this given the apparent confusion. --------- Co-authored-by: benesjan <janbenes1234@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12743
In this PR I rename occurrences of top-level unconstrained in docs.
Last PR in the crazy stack of renamings.