refactor: getManaBaseFeeComponentsAt are zeros when not canonical#12251
Merged
refactor: getManaBaseFeeComponentsAt are zeros when not canonical#12251
Conversation
This was referenced Feb 25, 2025
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
LHerskind
force-pushed
the
lh/10004-0-base-fee-no-canon
branch
from
96e702f to
210bb66
Compare
LHerskind
force-pushed
the
lh/12062-submission-libs
branch
from
f81364f to
ae110bb
Compare
LHerskind
force-pushed
the
lh/10004-0-base-fee-no-canon
branch
from
210bb66 to
fe05385
Compare
LHerskind
force-pushed
the
lh/12062-submission-libs
branch
from
ae110bb to
c4f6397
Compare
just-mitch
approved these changes
Feb 25, 2025
LHerskind
force-pushed
the
lh/10004-0-base-fee-no-canon
branch
from
fe05385 to
c1c42a8
Compare
LHerskind
force-pushed
the
lh/12062-submission-libs
branch
2 times, most recently
from
30036b3 to
fc82e91
Compare
LHerskind
force-pushed
the
lh/10004-0-base-fee-no-canon
branch
2 times, most recently
from
7bb9a3a to
b0b7ff3
Compare
LHerskind
force-pushed
the
lh/12062-submission-libs
branch
2 times, most recently
from
9a4b23c to
2084d12
Compare
LHerskind
force-pushed
the
lh/10004-0-base-fee-no-canon
branch
from
b0b7ff3 to
84502ad
Compare
Contributor
Author
|
This should also solve #12160 |
LHerskind
force-pushed
the
lh/10004-0-base-fee-no-canon
branch
from
84502ad to
9265311
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10004 by returning 0's when calling
getManaBaseFeeComponentsAt, also allowed us to slightly simpler check the header as we don't need the multiple paths then.