Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
| uint256 sequencerRewards = rollup.getSequencerRewards(sequencer); | ||
| vm.prank(sequencer); | ||
| uint256 sequencerRewardsClaimed = rollup.claimSequencerRewards(sequencer); | ||
| assertEq(sequencerRewardsClaimed, sequencerRewards, "Sequencer rewards not claimed"); |
There was a problem hiding this comment.
Can we also assert the value? Or at least assert greater than 0?
l1-contracts/test/MultiProof.t.sol
Outdated
| assertGt(bobRewards, 0, "Bob rewards is zero"); | ||
|
|
||
| vm.expectRevert( | ||
| abi.encodeWithSelector(Errors.Rollup__NotPastDeadline.selector, EPOCH_DURATION * 2, 2) |
There was a problem hiding this comment.
| abi.encodeWithSelector(Errors.Rollup__NotPastDeadline.selector, EPOCH_DURATION * 2, 2) | |
| abi.encodeWithSelector(Errors.Rollup__NotPastDeadline.selector, TestConstants.AZTEC_PROOF_SUBMISSION_WINDOW, 2) |
l1-contracts/test/MultiProof.t.sol
Outdated
| vm.prank(bob); | ||
| rollup.claimProverRewards(bob, epochs); | ||
|
|
||
| vm.warp(Timestamp.unwrap(rollup.getTimestampForSlot(Slot.wrap(EPOCH_DURATION * 2 + 1)))); |
|
Updated the For example, with epochs of size 32, the window was 64, meaning that the deadline would be at 64 for blocks in the first epoch meaning that it could happen in slot 64 which is in the third epoch, [0, ..., 31], [32, ..., 63], [64, ..., 95]. Instead we will use 2*epoch-1, to indicate that we must have the full epoch that the block is within and then |
2 participants
Fixes #11949.