Conversation
This was referenced Feb 17, 2025
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
LHerskind
force-pushed
the
lh/12001-delete-cheatcodes
branch
from
06574cd to
910ca9e
Compare
LHerskind
force-pushed
the
lh/12001-delete-cheatcodes
branch
from
910ca9e to
b51628e
Compare
LHerskind
force-pushed
the
lh/12001-delete-cheatcodes
branch
from
b51628e to
c720843
Compare
LHerskind
force-pushed
the
lh/12001-delete-cheatcodes
branch
from
c720843 to
fa3f88d
Compare
LHerskind
force-pushed
the
lh/12001-delete-cheatcodes
branch
from
fa3f88d to
7b09f15
Compare
Maddiaa0
reviewed
Feb 25, 2025
| uint256 manaUsed; | ||
| uint256 feeAssetPriceNumerator; | ||
| uint256 congestionCost; | ||
| uint256 provingCost; |
Member
There was a problem hiding this comment.
i assume the mentioned fee packing comes later
Contributor
Author
There was a problem hiding this comment.
Yep. Currently we cannot do a neat and nice gas-report due to how we are messing with the gas amounts in fees. So the plan was getting that going, and then dealing with the cost optimisations when we got that part going.
Maddiaa0
reviewed
Feb 25, 2025
| // Decode and validate header | ||
| Header memory header = ExtRollupLib.decodeHeader(_args.header); | ||
|
|
||
| // @todo As part of a refactor of the core for propose and submit, we should |
Contributor
Author
Maddiaa0
reviewed
Feb 25, 2025
Maddiaa0
approved these changes
Feb 25, 2025
just-mitch
approved these changes
Feb 25, 2025
TomAFrench
added a commit
that referenced
this pull request
Feb 26, 2025
* master: (92 commits) chore: Log prover publisher address on creation (#12267) feat: https for bootnode in devnet (#12161) feat(avm): support shifts in lookups (#12280) feat(docs): Add flamegraph tool to counter contract tutorial (#12202) feat(spartan): 192 node 1 tps - additional validator service (#12238) feat(avm): class id derivation (#12263) docs: Fees doc snippets and code snippets (#12229) refactor: proving cost in fee header (#12048) fix: prometheus scrapes itself in the cluster (#12277) feat: metrics (#12256) chore: cleanup stdlib internal imports (#12274) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg fix: Enforce no import side effects (#12268) refactor!: note interfaces (#12106) yolo undenoise tests feat: new transcript functionality to hash elements without including in proof (#12233) chore: remove gcloud metrics (#12265) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11941. Takes the simplest approach, store the value so we can just reuse it. Alternatively we would be doing a few re-computations, so with the plan that we can do a bit of storage packing this should turn out being the cheapest of the solutions.