chore: use cheatcodes instead of calling directly#12047
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
LHerskind
force-pushed
the
lh/12001-delete-cheatcodes
branch
from
87b9910 to
06574cd
Compare
LHerskind
force-pushed
the
lh/12001-delete-cheatcodes
branch
from
06574cd to
910ca9e
Compare
|
Running into some issues with a couple of the fee tests because the proving is now not happening, and marking as proven will not actually execute the logic and pay out. Fee tests need to be updated such that they are running with a simulated prover. |
LHerskind
force-pushed
the
lh/12001-delete-cheatcodes
branch
from
910ca9e to
b51628e
Compare
|
Running into some issues with a couple of the fee tests because the proving is now not happening, and marking as proven will not actually execute the logic and pay out. Fee tests need to be updated such that they are running with a simulated prover. Also see #12089 |
LHerskind
force-pushed
the
lh/12001-delete-cheatcodes
branch
from
b51628e to
c720843
Compare
LHerskind
force-pushed
the
lh/12001-delete-cheatcodes
branch
from
c720843 to
fa3f88d
Compare
LHerskind
force-pushed
the
lh/12001-delete-cheatcodes
branch
from
fa3f88d to
7b09f15
Compare
| this.logger.info( | ||
| `Proven tip moved: ${tipsBefore.proven} -> ${tipsAfter.proven}. Pending tip moved: ${tipsBefore.pending} -> ${tipsAfter.pending}`, | ||
| ); |
There was a problem hiding this comment.
Stupid question: why would the pending tip move, other than another block landing while this was happening?
There was a problem hiding this comment.
Oh, this was probably me brainfarting, I just wanted to see the pending chain as well, to make it explicit 😅. Should just have a "pending tip". as it as you say should not be moving.
| // @note @LHerskind this is heavily dependent on the storage layout and size of values | ||
| // The rollupStore is a struct and if the size of elements or the struct changes, this can break |
There was a problem hiding this comment.
I'd add a small test then, specifically for this bit
There was a problem hiding this comment.
One of the things further in the stack is breaking this because the slot change, but into more predictable with the diamond like storage setup, so were planning to deal with it in there #12063
3 participants
Fixes #12001.
Biggest changes:
assumeProvenThrough, no more calls to the contract to update that oneisMarkingAsProvenThe watcher chances could feel a little clunky. But as we are in most cases not testing the proving, this felt like the best way to make a sane default ("automining") and then require an extra step for the case of using a prover node or no proving at all.