Repository navigation
Debug Helper IDC Simulator: Add the ability to spoof the home url - #21516
Conversation
The Debug Helper plugin's IDC Simulator module allows the user to spoof the siteurl value. Let's add the ability to also spoof the home value. To do this, add two checkboxes that allow the user to choose whether to spoof the siteurl and/or home values. These checkboxes should be checked by default because the most common use case will be to spoof both values.
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Debug Helper plugin:
|
zinigor
left a comment
There was a problem hiding this comment.
Thanks, this is a great addition to the tool, and I like how you improved the filter logic! The UI will need some refactoring later on, but it's a debug tool, so it's OK for our purposes.
* master: (27 commits) Admin Page: Update upgrade buttons Tracks events (#21483) Debug Helper IDC Simulator: Add the ability to spoof the home url (#21516) Map block: Add `address` block attribute (#21412) Update wordpress monorepo (#21522) Stats Page: Add VideoPress nudge (#21513) Improve Jetpack products illustrations file size (#21514) Update dependency mediawiki/mediawiki-codesniffer to v38 (#21523) Update dependency yoast/phpunit-polyfills to v1.0.2 (#21524) Widgets: add Strava to Social Icons Widget and Social Menu (#21518) Boost: Add active modules to speed score request (#21471) Markdown: Better accessibility for Footnotes (#21495) Jetpack Plugin: Add VideoPress upgrade page (#21497) Admin Menu: moves Add new (plugin) menu item to the top for Atomic sites (#21506) General: Check the return value of get_comment() (#21080) Instagram Widget: link to user connection if user is not connected (#21512) Search: Create a new search package, rename Search plugin (#21502) Identity Crisis: Remove the unused jetpack_idc_option transient (#21492) Stats: do not update the wpcom blog details (#21441) Admin: do not display upgrade messages when on offline mode (#21444) jetpack: Catch calls to `exit()` and `die()` in PHPUnit (#21043) ...
Changes proposed in this Pull Request:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
a. Pointing your server requests to your sandbox by setting the
JETPACK__SANDBOX_DOMAINconstant. This will record request urls indebug.log.b. Causing a sync action to occur to trigger the sync request (for example, edit a post). Sync requests will include the siteurl and home values, so you can verify that they change as expected.
c. Note that your site will stop sending sync requests if it goes into an identity crisis. I prevent this by just leaving my server sandbox disabled.