[kbrown9]

Changes proposed in this Pull Request:

Currently, it's possible for the Stats module to change the WPCOM side siteurl value when the site is in an identity crisis, which is not the expected behavior. Only the Identity Crisis process should update the WPCOM side siteurl and home option values. Also, the data that is sent by the Stats module is handled by the Sync process, so it shouldn't be necessary for the Stats module to send it.

• Deprecate the stats_update_blog() function.
• Remove the stats_update_blog() call from stats_upgrade_options().

An alternate approach to this solve the identity crisis problem would be to just remove the siteurl option from the data that's sent in the jetpack.updateBlog request. However, it seems redundant to send any of this data since Sync handles it.

Jetpack product discussion

• n/a

Does this pull request change what data or activity we track or use?

• no

Testing instructions:

Suggested code review:

Confirm that the jetpack.updateBlog request sends data that is handled by Sync. The values that are sent by the call to jetpack.updateBlog are found in the stats_get_blog function. The default options that are sent by Sync are found in the Defaults::default_options_whitelist property. The siteurl option is synced via the site_url callable here.

Manual test:

1. Install and activate this branch of Jetpack.
2. Connect to WPCOM.
3. Get the blog id for your test site.
4. Using your sandbox, verify that that your test site's options that were updated by the call to jetpack.updateBlog are correct. (blogname, siteurl, stats_api, stats_options, etc.)

[test-case-reminder]

Here are some suggested test cases for this PR.

Stats

• Visit home page, make sure that page view is recorded in stats
• Visit home page in AMP view
• Visit post page in non-AMP and AMP view

If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

---

Jetpack plugin:

• Next scheduled release: November 2, 2021.
• Scheduled code freeze: October 25, 2021.

[leogermani]

I've verified that all the options that we updated via jetpack.updateBlog are handled by Sync.

From the options list, I saw that host, path, stats_api and stats_version were not handled by Sync, but these were also not handled by the XMLRPC endpoint, as we can see in Jetpack_XMLRPC_Server::sanitize_blog_option.

All options of my site looked fine even without this call (I watched my sandbox to see no calls coming in)

I also made sure to delete stats_options locally and saw it getting synced to WPCOM