Skip to content

Search: Create a new search package, rename Search plugin - #21502

Merged
jsnmoon merged 6 commits into
masterfrom
add/search-package
Oct 22, 2021
Merged

Search: Create a new search package, rename Search plugin#21502
jsnmoon merged 6 commits into
masterfrom
add/search-package

Conversation

@jsnmoon

@jsnmoon jsnmoon commented Oct 21, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes proposed in this Pull Request:

Jetpack product discussion

pcNPJE-oh-p2

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Ensure Github checks pass

@jsnmoon jsnmoon added [Feature] Search For all things related to Search [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Package] Search Contains core Search functionality for Jetpack and Search plugins labels Oct 21, 2021
@jsnmoon jsnmoon self-assigned this Oct 21, 2021
@github-actions

github-actions Bot commented Oct 21, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Search plugin:

  • Next scheduled release: November 2, 2021.
  • Scheduled code freeze: October 25, 2021.

@jsnmoon
jsnmoon force-pushed the add/search-package branch from 6111fb8 to 39033dd Compare October 21, 2021 22:15
@jsnmoon
jsnmoon requested a review from a team October 21, 2021 22:42
@jsnmoon jsnmoon added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Oct 21, 2021
jeherve
jeherve approved these changes Oct 22, 2021
View reviewed changes

@jeherve jeherve left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think it would be nice to have a readme for that new package to make it clear to folks who may have been watching that package to keep up with development of the standalone plugin, but that's not a blocker, it can be done later I think.

Note: I created the new repo and Packagist entry for the new plugin location, so this should be good to merge, the package and the plugin will get pushed to the right location on merge.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Oct 22, 2021
@jeherve jeherve added this to the search/0.1.0 milestone Oct 22, 2021
@anomiex

anomiex commented Oct 22, 2021

Copy link
Copy Markdown
Contributor

You created the new mirror repo for the plugin, but after this is merged someone should do the work to also transfer the history from the old repo. Otherwise the new mirror will lack any history, and the new package in the old repo will weirdly reflect the history for the plugin.

The "about" text and tags in the old repo could probably use updating too. Fortunately there aren't any releases or tags to figure out how to move over.

@jeherve

jeherve commented Oct 22, 2021

Copy link
Copy Markdown
Member

Otherwise the new mirror will lack any history, and the new package in the old repo will weirdly reflect the history for the plugin.

That may be fine in this case, since not a lot has happened with Automattic/jetpack-search since its creation. The plugin was never functional and never released.

The "about" text and tags in the old repo could probably use updating too.

That's a good point. We can update them once this has been merged.

@anomiex

anomiex commented Oct 22, 2021

Copy link
Copy Markdown
Contributor

Still probably better for the 13 commits to the plugin to be in the plugin's repo. If no one else wants to do it, poke me once this is merged and I'll take care of it. I don't mind.

@jsnmoon jsnmoon changed the title Search: Create a new search package & rename Search plugin package Search: Create a new search package, rename Search plugin Oct 22, 2021
@jsnmoon
jsnmoon merged commit 3d9496d into master Oct 22, 2021
@jsnmoon
jsnmoon deleted the add/search-package branch October 22, 2021 21:03
@jsnmoon

jsnmoon commented Oct 22, 2021

Copy link
Copy Markdown
Contributor Author

@anomiex: Pinging you in case you still wanted to transfer the repo history 👍

@github-actions github-actions Bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 22, 2021
@anomiex

anomiex commented Oct 25, 2021

Copy link
Copy Markdown
Contributor

Done, history fixed in both repos.

davidlonjon added a commit that referenced this pull request Oct 26, 2021
@davidlonjon
Merge branch 'master' into add/boost-e2e-ci-integration
b4a66c0 
* master: (27 commits)
  Admin Page: Update upgrade buttons Tracks events (#21483)
  Debug Helper IDC Simulator: Add the ability to spoof the home url (#21516)
  Map block: Add `address` block attribute (#21412)
  Update wordpress monorepo (#21522)
  Stats Page: Add VideoPress nudge (#21513)
  Improve Jetpack products illustrations file size (#21514)
  Update dependency mediawiki/mediawiki-codesniffer to v38 (#21523)
  Update dependency yoast/phpunit-polyfills to v1.0.2 (#21524)
  Widgets: add Strava to Social Icons Widget and Social Menu (#21518)
  Boost: Add active modules to speed score request (#21471)
  Markdown: Better accessibility for Footnotes (#21495)
  Jetpack Plugin: Add VideoPress upgrade page (#21497)
  Admin Menu: moves Add new (plugin) menu item to the top for Atomic sites (#21506)
  General: Check the return value of get_comment() (#21080)
  Instagram Widget: link to user connection if user is not connected (#21512)
  Search: Create a new search package, rename Search plugin (#21502)
  Identity Crisis: Remove the unused jetpack_idc_option transient (#21492)
  Stats: do not update the wpcom blog details (#21441)
  Admin: do not display upgrade messages when on offline mode (#21444)
  jetpack: Catch calls to `exit()` and `die()` in PHPUnit (#21043)
  ...
This was referenced Oct 7, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@jsnmoon jsnmoon

Labels

[Feature] Search For all things related to Search [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster.

Projects

None yet

Milestone

search/0.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jsnmoon @anomiex @jeherve