[anomiex]

Changes proposed in this Pull Request:

It's too easy to wind up having WordPress just exit(), for example by
having something call wp_die() while wp_doing_ajax() returns true.

Let's use antecedent/patchwork (which we already use as part of
brain/monkey in a bunch of package tests) to redefine these functions to
throw an exception instead, which PHPUnit will catch.

Jetpack product discussion

p9dueE-3sh-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

• Is CI happy?
• Add an exit() call somewhere in code covered by a test. Does PHPUnit still run to completion, with the relevant test showing that an unexpected ExitException was thrown?

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

---

Jetpack plugin:

• Next scheduled release: November 2, 2021.
• Scheduled code freeze: October 25, 2021.

[brbrr]

I like the approach. Although, I'm not sure how it actually works. There is an unrelated(?) failure in CI, and then there is a fatal ExitException thrown. I'm not sure if these are two separate errors, or somehow related. Also, fatal's stack trace is not useful at all, but it's probably better than nothing 😬

https://github.com/Automattic/jetpack/pull/21043/checks?check_run_id=3569848661#step:9:210

[anomiex]

So unfortunately it's not self-testing after all because GH merges with master and master already has the fix.

The ExitException that was thrown there is a bug, which should be fixed by 3dc3d01. I didn't notice it locally because the Docker env uses a phar and a wrapper that loads all the PHPUnit classes before calling the bootstrap, while CI installs via composer global which loads the PHPUnit classes as needed via an autoloader.

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello anomiex! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D66707-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

[anomiex]

The PHP 8 failure is a Patchwork bug, antecedent/patchwork#117.

[anomiex]

Finally there's a release of patchwork to fix the bug, so this can be ready to review again.

[github-actions]

Great news! One last step: head over to your WordPress.com diff, D66707-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

[anomiex]

r233809-wpcom